Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1495)

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc

Issue 380813003: Remove remaining overrides of View::HitTestRect() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: DoesIntersectRect() overrides made private Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
index 6b3956817a13098feab249625e1cec74692ca786..9f0eed77ba83af796ca307dd18f8bedd3266bd4b 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
@@ -289,47 +289,6 @@ void OpaqueBrowserFrameView::UpdateWindowTitle() {
///////////////////////////////////////////////////////////////////////////////
// OpaqueBrowserFrameView, views::View overrides:
-bool OpaqueBrowserFrameView::HitTestRect(const gfx::Rect& rect) const {
- if (!views::View::HitTestRect(rect)) {
- // |rect| is outside OpaqueBrowserFrameView's bounds.
- return false;
- }
-
- // If the rect is outside the bounds of the client area, claim it.
- gfx::RectF rect_in_client_view_coords_f(rect);
- View::ConvertRectToTarget(this, frame()->client_view(),
- &rect_in_client_view_coords_f);
- gfx::Rect rect_in_client_view_coords = gfx::ToEnclosingRect(
- rect_in_client_view_coords_f);
- if (!frame()->client_view()->HitTestRect(rect_in_client_view_coords))
- return true;
-
- // Otherwise, claim |rect| only if it is above the bottom of the tabstrip in
- // a non-tab portion.
- TabStrip* tabstrip = browser_view()->tabstrip();
- if (!tabstrip || !browser_view()->IsTabStripVisible())
- return false;
-
- gfx::RectF rect_in_tabstrip_coords_f(rect);
- View::ConvertRectToTarget(this, tabstrip, &rect_in_tabstrip_coords_f);
- gfx::Rect rect_in_tabstrip_coords = gfx::ToEnclosingRect(
- rect_in_tabstrip_coords_f);
- if (rect_in_tabstrip_coords.bottom() > tabstrip->GetLocalBounds().bottom()) {
- // |rect| is below the tabstrip.
- return false;
- }
-
- if (tabstrip->HitTestRect(rect_in_tabstrip_coords)) {
- // Claim |rect| if it is in a non-tab portion of the tabstrip.
- return tabstrip->IsRectInWindowCaption(rect_in_tabstrip_coords);
- }
-
- // We claim |rect| because it is above the bottom of the tabstrip, but
- // not in the tabstrip itself. In particular, the avatar label/button is left
- // of the tabstrip and the window controls are right of the tabstrip.
- return true;
-}
-
void OpaqueBrowserFrameView::GetAccessibleState(
ui::AXViewState* state) {
state->role = ui::AX_ROLE_TITLE_BAR;
@@ -521,6 +480,50 @@ void OpaqueBrowserFrameView::OnPaint(gfx::Canvas* canvas) {
///////////////////////////////////////////////////////////////////////////////
// OpaqueBrowserFrameView, private:
+// views::NonClientFrameView:
+bool OpaqueBrowserFrameView::DoesIntersectRect(const views::View* target,
+ const gfx::Rect& rect) const {
+ CHECK_EQ(target, this);
+ if (!views::ViewTargeterDelegate::DoesIntersectRect(this, rect)) {
+ // |rect| is outside OpaqueBrowserFrameView's bounds.
+ return false;
+ }
+
+ // If the rect is outside the bounds of the client area, claim it.
+ gfx::RectF rect_in_client_view_coords_f(rect);
+ View::ConvertRectToTarget(this, frame()->client_view(),
+ &rect_in_client_view_coords_f);
+ gfx::Rect rect_in_client_view_coords = gfx::ToEnclosingRect(
+ rect_in_client_view_coords_f);
+ if (!frame()->client_view()->HitTestRect(rect_in_client_view_coords))
+ return true;
+
+ // Otherwise, claim |rect| only if it is above the bottom of the tabstrip in
+ // a non-tab portion.
+ TabStrip* tabstrip = browser_view()->tabstrip();
+ if (!tabstrip || !browser_view()->IsTabStripVisible())
+ return false;
+
+ gfx::RectF rect_in_tabstrip_coords_f(rect);
+ View::ConvertRectToTarget(this, tabstrip, &rect_in_tabstrip_coords_f);
+ gfx::Rect rect_in_tabstrip_coords = gfx::ToEnclosingRect(
+ rect_in_tabstrip_coords_f);
+ if (rect_in_tabstrip_coords.bottom() > tabstrip->GetLocalBounds().bottom()) {
+ // |rect| is below the tabstrip.
+ return false;
+ }
+
+ if (tabstrip->HitTestRect(rect_in_tabstrip_coords)) {
+ // Claim |rect| if it is in a non-tab portion of the tabstrip.
+ return tabstrip->IsRectInWindowCaption(rect_in_tabstrip_coords);
+ }
+
+ // We claim |rect| because it is above the bottom of the tabstrip, but
+ // not in the tabstrip itself. In particular, the avatar label/button is left
+ // of the tabstrip and the window controls are right of the tabstrip.
+ return true;
+}
+
views::ImageButton* OpaqueBrowserFrameView::InitWindowCaptionButton(
int normal_image_id,
int hot_image_id,
« no previous file with comments | « chrome/browser/ui/views/frame/opaque_browser_frame_view.h ('k') | chrome/browser/ui/views/profiles/avatar_menu_button.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698