Issue 380803002: Update smoothness_controller to use results.AddValue(...)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 380803002: Update smoothness_controller to use results.AddValue(...) (Closed)

Created:
6 years, 5 months ago by nednguyen

Modified:
6 years, 5 months ago

Reviewers:
nduca

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Update smoothness_controller to use results.AddValue(...) BUG=391943 TBR=nduca@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282131

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	tools/perf/measurements/smoothness_controller.py	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/380803002/1

6 years, 5 months ago (2014-07-09 16:42:24 UTC) #2

dgrogan

6 years, 5 months ago (2014-07-09 22:57:53 UTC) #4

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/382673003/ by dgrogan@chromium.org.

The reason for reverting is: Possibly caused Android Tests failures. See
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14...

E.g.
Traceback (most recent call last):
  _RunPage at tools/telemetry/telemetry/page/page_runner.py:534
    test.RunPage(page, page_state.tab, results)
  RunPage at tools/telemetry/telemetry/page/page_test.py:247
    self.ValidatePage(page, tab, results)
  ValidatePage at tools/telemetry/telemetry/page/page_measurement.py:60
    self.MeasurePage(page, tab, results)
  MeasurePage at tools/perf/measurements/smoothness.py:36
    self._smoothness_controller.AddResults(tab, results)
  AddResults at tools/perf/measurements/smoothness_controller.py:100
    results.current_page, r.name, r.unit, r.value))
  __init__ at tools/telemetry/telemetry/value/scalar.py:19
    assert isinstance(value, numbers.Number)
AssertionError.

Expand Messages | Collapse Messages