tools/perf/measurements/screenshot.py - Issue 380783003: Update screenshot to use results.AddValue(...)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/screenshot.py

Issue 380783003: Update screenshot to use results.AddValue(...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/screenshot.py

diff --git a/tools/perf/measurements/screenshot.py b/tools/perf/measurements/screenshot.py

index 1459bcecea642d258c154ba6f64b33efa10e9f4b..193669f62dd95cfbe2eda5bbc55253fdc90344eb 100644

--- a/tools/perf/measurements/screenshot.py

+++ b/tools/perf/measurements/screenshot.py

@@ -5,6 +5,7 @@ import os

from telemetry.page import page_measurement

from telemetry.page import page_test

+from telemetry.value import scalar

class Screenshot(page_measurement.PageMeasurement):

@@ -45,4 +46,6 @@ class Screenshot(page_measurement.PageMeasurement):

saved_picture_count = 0

if os.path.exists(outpath) and os.path.getmtime(outpath) > previous_mtime:

saved_picture_count = 1

- results.Add('saved_picture_count', 'count', saved_picture_count)

+ results.AddValue(scalar.ScalarValue(

+ results.current_page, 'saved_picture_count', 'count',

+ saved_picture_count))

« no previous file with comments | « no previous file | no next file » | no next file with comments »