Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: components/nacl/renderer/pnacl_translation_resource_host.h

Issue 380773002: Pepper: Use base::Callback in RequestNexeFd. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: TrackedCallback ugh Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/nacl/renderer/pnacl_translation_resource_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/renderer/pnacl_translation_resource_host.h
diff --git a/components/nacl/renderer/pnacl_translation_resource_host.h b/components/nacl/renderer/pnacl_translation_resource_host.h
index 5a92f8e19c46bcd07b7bd90a9e24db1e30829872..18441ce0e87245ecfb07e4b27452a3ef921cd0ce 100644
--- a/components/nacl/renderer/pnacl_translation_resource_host.h
+++ b/components/nacl/renderer/pnacl_translation_resource_host.h
@@ -7,10 +7,13 @@
#include <map>
+#include "base/callback.h"
+#include "base/message_loop/message_loop_proxy.h"
#include "ipc/ipc_platform_file.h"
#include "ipc/message_filter.h"
+#include "ppapi/c/pp_bool.h"
+#include "ppapi/c/pp_instance.h"
#include "ppapi/c/private/pp_file_handle.h"
-#include "ppapi/shared_impl/tracked_callback.h"
namespace nacl {
struct PnaclCacheInfo;
@@ -24,36 +27,25 @@ struct PnaclCacheInfo;
// needs from the browser since "Resource" is a Pepper thing...
class PnaclTranslationResourceHost : public IPC::MessageFilter {
public:
+ typedef base::Callback<void(int32_t, bool, PP_FileHandle)>
+ RequestNexeFdCallback;
+
explicit PnaclTranslationResourceHost(
const scoped_refptr<base::MessageLoopProxy>& io_message_loop);
void RequestNexeFd(int render_view_id,
PP_Instance instance,
const nacl::PnaclCacheInfo& cache_info,
- PP_Bool* is_hit,
- PP_FileHandle* file_handle,
- scoped_refptr<ppapi::TrackedCallback> callback);
+ RequestNexeFdCallback callback);
void ReportTranslationFinished(PP_Instance instance, PP_Bool success);
protected:
virtual ~PnaclTranslationResourceHost();
private:
- class CacheRequestInfo {
- public:
- CacheRequestInfo(PP_Bool* hit,
- PP_FileHandle* handle,
- scoped_refptr<ppapi::TrackedCallback> cb);
-
- ~CacheRequestInfo();
-
- PP_Bool* is_hit;
- PP_FileHandle* file_handle;
- scoped_refptr<ppapi::TrackedCallback> callback;
- };
-
// Maps the instance with an outstanding cache request to the info
// about that request.
- typedef std::map<PP_Instance, CacheRequestInfo> CacheRequestInfoMap;
+ typedef std::map<PP_Instance, RequestNexeFdCallback> CacheRequestInfoMap;
+
// IPC::MessageFilter implementation.
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
virtual void OnFilterAdded(IPC::Sender* sender) OVERRIDE;
@@ -63,9 +55,7 @@ class PnaclTranslationResourceHost : public IPC::MessageFilter {
void SendRequestNexeFd(int render_view_id,
PP_Instance instance,
const nacl::PnaclCacheInfo& cache_info,
- PP_Bool* is_hit,
- PP_FileHandle* file_handle,
- scoped_refptr<ppapi::TrackedCallback> callback);
+ RequestNexeFdCallback callback);
void SendReportTranslationFinished(PP_Instance instance,
PP_Bool success);
void OnNexeTempFileReply(PP_Instance instance,
« no previous file with comments | « no previous file | components/nacl/renderer/pnacl_translation_resource_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698