[Win] Ctrl+W should close the User Manager

[Win] Ctrl+W should close the User Manager

BUG=364644
TEST=Start Chrome with --new-profile-management turned on. From the avatar
menu, select "Not <name>". The User Manager should show up. Ctrl+W should
close it, but other accelerators (eg. Ctrl+t) should not work.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282128

[noms (inactive), 2014-07-09 15:13:57]

Hi Mike,

I've added an accelerator to the User Manager to close it. Unfortunately,
because of enabling accelerators on the WebView, this also adds a
"free-i-didn't-ask-for-it" VKEY_ESCAPE accelerator, that also closes it. Do you
have any ideas how I could prevent Esc?

[msw, 2014-07-09 16:21:33]

Both Esc and Ctrl+W close the Task Manager, so Esc closing this seems fine.
(Esc is an accelerator for DialogClientView or its Cancel/OK buttons).

Maybe disallow accelerators on the client view if Esc really should no-op.
(that'll also prevent Enter from invoking any okay button, I suppose)

[noms (inactive), 2014-07-09 17:02:05]

Thanks, that did the trick. Please take another look :)

Reason for preventing esc: the User Manager is kind of like a "top level"
browser window. Since it can be the only window open, closing it can quit
Chrome, which I think is a bit of an annoyance if all you want to do is unfocus
one of the html pods being displayed.

[msw, 2014-07-09 17:07:03]

lgtm with a nit; I still support allowing Esc, though.

https://codereview.chromium.org/380763003/diff/60001/chrome/browser/ui/views/...
File chrome/browser/ui/views/profiles/user_manager_view.cc (right):

https://codereview.chromium.org/380763003/diff/60001/chrome/browser/ui/views/...
chrome/browser/ui/views/profiles/user_manager_view.cc:115:
GetDialogClientView()->RemoveAccelerator(
nit: add a comment explaining why Esc shouldn't close the window.

[noms (inactive), 2014-07-09 17:15:09]

https://codereview.chromium.org/380763003/diff/60001/chrome/browser/ui/views/...
File chrome/browser/ui/views/profiles/user_manager_view.cc (right):

https://codereview.chromium.org/380763003/diff/60001/chrome/browser/ui/views/...
chrome/browser/ui/views/profiles/user_manager_view.cc:115:
GetDialogClientView()->RemoveAccelerator(
On 2014/07/09 17:07:03, msw wrote:
> nit: add a comment explaining why Esc shouldn't close the window.

Done.

[noms (inactive), 2014-07-09 18:10:16]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-07-09 18:11:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noms@chromium.org/380763003/80001

[commit-bot: I haz the power, 2014-07-09 21:27:13]

Change committed as 282128