Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: cc/quads/render_pass_draw_quad.cc

Issue 380763002: Add builders for tracing event's structural arguments (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed memory leak found by Linux ASAN Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/quads/render_pass_draw_quad.h ('k') | cc/quads/shared_quad_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/quads/render_pass_draw_quad.cc
diff --git a/cc/quads/render_pass_draw_quad.cc b/cc/quads/render_pass_draw_quad.cc
index 6259fdf4afbb57c9d3b2ac53810ec114e67a275a..380f2f6619337e1d8af761f148c32adff1df537e 100644
--- a/cc/quads/render_pass_draw_quad.cc
+++ b/cc/quads/render_pass_draw_quad.cc
@@ -4,6 +4,7 @@
#include "cc/quads/render_pass_draw_quad.h"
+#include "base/debug/trace_event_argument.h"
#include "base/values.h"
#include "cc/base/math_util.h"
#include "cc/debug/traced_value.h"
@@ -81,16 +82,24 @@ const RenderPassDrawQuad* RenderPassDrawQuad::MaterialCast(
return static_cast<const RenderPassDrawQuad*>(quad);
}
-void RenderPassDrawQuad::ExtendValue(base::DictionaryValue* value) const {
- value->Set("render_pass_id",
- TracedValue::CreateIDRef(render_pass_id.AsTracingId()).release());
+void RenderPassDrawQuad::ExtendValue(base::debug::TracedValue* value) const {
+ TracedValue::SetIDRef(render_pass_id.AsTracingId(), value, "render_pass_id");
value->SetBoolean("is_replica", is_replica);
value->SetInteger("mask_resource_id", mask_resource_id);
- value->Set("contents_changed_since_last_frame",
- MathUtil::AsValue(contents_changed_since_last_frame).release());
- value->Set("mask_uv_rect", MathUtil::AsValue(mask_uv_rect).release());
- value->Set("filters", filters.AsValue().release());
- value->Set("background_filters", background_filters.AsValue().release());
+ value->BeginArray("contents_changed_since_last_frame");
+ MathUtil::AddToTracedValue(contents_changed_since_last_frame, value);
+ value->EndArray();
+
+ value->BeginArray("mask_uv_rect");
+ MathUtil::AddToTracedValue(mask_uv_rect, value);
+ value->EndArray();
+ value->BeginDictionary("filters");
+ filters.AsValueInto(value);
+ value->EndDictionary();
+
+ value->BeginDictionary("background_filters");
+ background_filters.AsValueInto(value);
+ value->EndDictionary();
}
} // namespace cc
« no previous file with comments | « cc/quads/render_pass_draw_quad.h ('k') | cc/quads/shared_quad_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698