Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2751)

Unified Diff: cc/quads/draw_quad.h

Issue 380763002: Add builders for tracing event's structural arguments (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed memory leak found by Linux ASAN Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/quads/debug_border_draw_quad.cc ('k') | cc/quads/draw_quad.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/quads/draw_quad.h
diff --git a/cc/quads/draw_quad.h b/cc/quads/draw_quad.h
index 07193cd067d4bb41b6cb39be2ce968ecd5a1f323..61ca35863f44b42f804845780d5d9c22e0256961 100644
--- a/cc/quads/draw_quad.h
+++ b/cc/quads/draw_quad.h
@@ -11,6 +11,9 @@
#include "cc/resources/resource_provider.h"
namespace base {
+namespace debug {
+class TracedValue;
+}
class Value;
class DictionaryValue;
}
@@ -123,7 +126,7 @@ class CC_EXPORT DrawQuad {
return IsLeftEdge() || IsTopEdge() || IsRightEdge() || IsBottomEdge();
}
- scoped_ptr<base::Value> AsValue() const;
+ void AsValueInto(base::debug::TracedValue* value) const;
protected:
DrawQuad();
@@ -134,7 +137,7 @@ class CC_EXPORT DrawQuad {
const gfx::Rect& opaque_rect,
const gfx::Rect& visible_rect,
bool needs_blending);
- virtual void ExtendValue(base::DictionaryValue* value) const = 0;
+ virtual void ExtendValue(base::debug::TracedValue* value) const = 0;
};
} // namespace cc
« no previous file with comments | « cc/quads/debug_border_draw_quad.cc ('k') | cc/quads/draw_quad.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698