Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: cc/output/filter_operations.cc

Issue 380763002: Add builders for tracing event's structural arguments (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed memory leak found by Linux ASAN Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/filter_operations.h ('k') | cc/quads/checkerboard_draw_quad.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/filter_operations.cc
diff --git a/cc/output/filter_operations.cc b/cc/output/filter_operations.cc
index 443d7ecae6e556542ce1814a79c61c382418bb8e..dcdd4803fd60756b00ed365c8926573b4431eecf 100644
--- a/cc/output/filter_operations.cc
+++ b/cc/output/filter_operations.cc
@@ -2,10 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include <cmath>
-
#include "cc/output/filter_operations.h"
+#include <cmath>
+
+#include "base/debug/trace_event_argument.h"
#include "base/values.h"
#include "cc/output/filter_operation.h"
@@ -196,11 +197,12 @@ FilterOperations FilterOperations::Blend(const FilterOperations& from,
return blended_filters;
}
-scoped_ptr<base::Value> FilterOperations::AsValue() const {
- scoped_ptr<base::ListValue> value(new base::ListValue);
- for (size_t i = 0; i < operations_.size(); ++i)
- value->Append(operations_[i].AsValue().release());
- return value.PassAs<base::Value>();
+void FilterOperations::AsValueInto(base::debug::TracedValue* value) const {
+ for (size_t i = 0; i < operations_.size(); ++i) {
+ value->BeginDictionary();
+ operations_[i].AsValueInto(value);
+ value->EndDictionary();
+ }
}
} // namespace cc
« no previous file with comments | « cc/output/filter_operations.h ('k') | cc/quads/checkerboard_draw_quad.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698