Issue 380733002: Add the Polymer object observe library and add a test that it works.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 380733002: Add the Polymer object observe library and add a test that it works. (Closed)

Created:
6 years, 5 months ago by jcgregorio

Modified:
6 years, 5 months ago

Reviewers:
kelvinly

CC:
reviews_skia.org, benchen

Base URL:
https://skia.googlesource.com/buildbot.git@master

Project:
skiabuildbot

Visibility:
Public.

Add the Polymer object observe library and add a test that it works. Docs are here: https://github.com/Polymer/observe-js In the main code we will have to check if Object.observe is available, and if not we'll need to call Platform.performMicrotaskCheckpoint every 125ms using setTimeout. BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/f1cb904a3cbcb912819e80a742f3425a0eaab23e

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -35 lines)			Patch
M	perf/server/Gruntfile.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	perf/server/Makefile	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	perf/server/bower.json	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	perf/server/karma.conf.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	perf/server/res/js/logic.js	View	1	25 chunks	+32 lines, -32 lines	0 comments	Download
A	perf/server/tests/oobserve.js	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/380733002/20001

6 years, 5 months ago (2014-07-09 14:21:55 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-07-09 14:22:15 UTC) #5

Message was sent while issue was closed.

Change committed as f1cb904a3cbcb912819e80a742f3425a0eaab23e