ash/wm/dock/docked_window_layout_manager.cc - Issue 38073004: Not moving a docked window when restoring a previously maximized window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/dock/docked_window_layout_manager.cc

Issue 38073004: Not moving a docked window when restoring a previously maximized window (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Not moving a docked window when restoring a previously maximized window (delegating IsDocked to non… Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/wm/dock/docked_window_layout_manager.cc

diff --git a/ash/wm/dock/docked_window_layout_manager.cc b/ash/wm/dock/docked_window_layout_manager.cc

index 3307d6c95209fc98fc416f0b561322bba4884a97..03a85cedeb396e6f76aed93db7755a351ec6a5a3 100644

--- a/ash/wm/dock/docked_window_layout_manager.cc

+++ b/ash/wm/dock/docked_window_layout_manager.cc

@@ -576,7 +576,7 @@ void DockedWindowLayoutManager::OnWindowShowTypeChanged(

// Reparenting changes the source bounds for the animation if a window is

// visible so hide it here and show later when it is already in the desktop.

UndockWindow(window);

- } else {

+ } else if (old_type == wm::SHOW_TYPE_MINIMIZED) {

RestoreDockedWindow(window_state);

}

« no previous file with comments | « ash/wm/custom_frame_view_ash.cc ('k') | ash/wm/panels/panel_frame_view.h » ('j') | ui/views/widget/widget.h » ('J')