Not moving a docked window when restoring a previously maximized window

ui/views/widget/widget.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_WIDGET_WIDGET_H_
 #define UI_VIEWS_WIDGET_WIDGET_H_
 
 #include <set>
 #include <stack>
 #include <vector>
@@ skipping 460 matching lines @@
   void Restore();
 
   // Whether or not the window is maximized or minimized.
   virtual bool IsMaximized() const;
   bool IsMinimized() const;
 
   // Accessors for fullscreen state.
   void SetFullscreen(bool fullscreen);
   bool IsFullscreen() const;
 
+  // Whether the window is docked (only possible on Ash).
+  bool IsDocked() const;

[sky, 2013/10/29 16:36:06]

Ben is trying to keep ash specific state out of views. Can you move this where
you need it? Same comment on all the changes you're adding to ui/views.

[varkha, 2013/10/29 17:06:18]

Not sure I follow. How can I not introduce something to ui/views and at the same
time eliminate ash-specific ifdefs in TabDragController?
I could introduce docked as a property (there is GetNativeWindowProperty) but I
thought you didn't like that approach either.
Or do you mean just moving that chain of invocations to a method in
TabDragController (although then it would need to be ifdefed with USE_ASH)?

[varkha, 2013/10/29 18:28:03]

Done.

+
   // Sets the opacity of the widget. This may allow widgets behind the widget
   // in the Z-order to become visible, depending on the capabilities of the
   // underlying windowing system.
   void SetOpacity(unsigned char opacity);
 
   // Sets whether or not the window should show its frame as a "transient drag
   // frame" - slightly transparent and without the standard window controls.
   void SetUseDragFrame(bool use_drag_frame);
 
   // Flashes the frame of the window to draw attention to it. Currently only
@@ skipping 401 matching lines @@
   // True when window movement via mouse interaction with the frame should be
   // disabled.
   bool movement_disabled_;
 
   DISALLOW_COPY_AND_ASSIGN(Widget);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_WIDGET_WIDGET_H_