Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: components/password_manager/core/common/password_manager_pref_names.cc

Issue 380713003: PasswordManager - update "password_manager_enabled_" pref name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Trybots failure (rebase was needed) Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/common/password_manager_pref_names.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/common/password_manager_pref_names.cc
diff --git a/components/password_manager/core/common/password_manager_pref_names.cc b/components/password_manager/core/common/password_manager_pref_names.cc
index e4c9aab675f7f2c1602ebe8fa8976fba0987c248..39fac8822924a780a43dd4c3426d578b2ca686a0 100644
--- a/components/password_manager/core/common/password_manager_pref_names.cc
+++ b/components/password_manager/core/common/password_manager_pref_names.cc
@@ -23,9 +23,13 @@ const char kOsPasswordLastChanged[] =
const char kPasswordManagerAllowShowPasswords[] =
"profile.password_manager_allow_show_passwords";
-// Boolean that is true if the password manager is on (will record new
-// passwords and fill in known passwords).
-const char kPasswordManagerEnabled[] = "profile.password_manager_enabled";
+// Boolean that is true if password saving is on (will record new
+// passwords and fill in known passwords). When it is false, it doesn't
+// ask if you want to save passwords but will continue to fill passwords.
+// Constant name and its value differ because of historical reasons as it
+// was not deemed important enough to add migration code just for name change.
+// See http://crbug.com/392387
+const char kPasswordManagerSavingEnabled[] = "profile.password_manager_enabled";
// A list of numbers. Each number corresponds to one of the domains monitored
// for save-password-prompt breakages. That number is a random index into
« no previous file with comments | « components/password_manager/core/common/password_manager_pref_names.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698