components/password_manager/core/browser/password_manager_unittest.cc - Issue 380713003: PasswordManager - update "password_manager_enabled_" pref name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 380713003: PasswordManager - update "password_manager_enabled_" pref name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Trybots failure (rebase was needed) Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager.cc ('k') | components/password_manager/core/common/password_manager_pref_names.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc

index a5a9ed4ea48caabc7b720b64bbe8290908f52a76..d4ed8cb27a3e610a8207e96469776c16b674ec43 100644

--- a/components/password_manager/core/browser/password_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_manager_unittest.cc

@@ -76,7 +76,7 @@ class TestPasswordManager : public PasswordManager {

class PasswordManagerTest : public testing::Test {

protected:

virtual void SetUp() {

- prefs_.registry()->RegisterBooleanPref(prefs::kPasswordManagerEnabled,

+ prefs_.registry()->RegisterBooleanPref(prefs::kPasswordManagerSavingEnabled,

true);

store_ = new MockPasswordStore;

@@ -484,10 +484,10 @@ TEST_F(PasswordManagerTest, InitiallyInvisibleForm) {

TEST_F(PasswordManagerTest, SavingDependsOnManagerEnabledPreference) {

// Test that saving passwords depends on the password manager enabled

// preference.

- prefs_.SetUserPref(prefs::kPasswordManagerEnabled,

+ prefs_.SetUserPref(prefs::kPasswordManagerSavingEnabled,

base::Value::CreateBooleanValue(true));

EXPECT_TRUE(manager()->IsSavingEnabledForCurrentPage());

- prefs_.SetUserPref(prefs::kPasswordManagerEnabled,

+ prefs_.SetUserPref(prefs::kPasswordManagerSavingEnabled,

base::Value::CreateBooleanValue(false));

EXPECT_FALSE(manager()->IsSavingEnabledForCurrentPage());

}

@@ -498,7 +498,7 @@ TEST_F(PasswordManagerTest, FillPasswordsOnDisabledManager) {

std::vector<PasswordForm*> result;

PasswordForm* existing = new PasswordForm(MakeSimpleForm());

result.push_back(existing);

- prefs_.SetUserPref(prefs::kPasswordManagerEnabled,

+ prefs_.SetUserPref(prefs::kPasswordManagerSavingEnabled,

base::Value::CreateBooleanValue(false));

EXPECT_CALL(driver_, FillPasswordForm(_));

EXPECT_CALL(*store_.get(),