Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: components/password_manager/core/browser/password_generation_manager_unittest.cc

Issue 380713003: PasswordManager - update "password_manager_enabled_" pref name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Trybots failure (rebase was needed) Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_generation_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_generation_manager_unittest.cc b/components/password_manager/core/browser/password_generation_manager_unittest.cc
index e17ba7c25467c9e4a1d6a5ec1e21dad9d6dab7b9..cf240c2af920ed9389805feb356afbe63ad16668 100644
--- a/components/password_manager/core/browser/password_generation_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_generation_manager_unittest.cc
@@ -111,7 +111,7 @@ class PasswordGenerationManagerTest : public testing::Test {
// it off to |client_|, as the initialization flow of |client_| will
// indirectly cause those prefs to be immediately accessed.
scoped_ptr<TestingPrefServiceSimple> prefs(new TestingPrefServiceSimple());
- prefs->registry()->RegisterBooleanPref(prefs::kPasswordManagerEnabled,
+ prefs->registry()->RegisterBooleanPref(prefs::kPasswordManagerSavingEnabled,
true);
client_.reset(new TestPasswordManagerClient(prefs.PassAs<PrefService>()));
}
@@ -142,7 +142,7 @@ TEST_F(PasswordGenerationManagerTest, IsGenerationEnabled) {
// Enabling the PasswordManager and password sync should cause generation to
// be enabled.
PrefService* prefs = client_->GetPrefs();
- prefs->SetBoolean(prefs::kPasswordManagerEnabled, true);
+ prefs->SetBoolean(prefs::kPasswordManagerSavingEnabled, true);
client_->set_is_password_sync_enabled(true);
EXPECT_TRUE(IsGenerationEnabled());
@@ -152,7 +152,7 @@ TEST_F(PasswordGenerationManagerTest, IsGenerationEnabled) {
// Disabling the PasswordManager should cause generation to be disabled even
// if syncing is enabled.
- prefs->SetBoolean(prefs::kPasswordManagerEnabled, false);
+ prefs->SetBoolean(prefs::kPasswordManagerSavingEnabled, false);
client_->set_is_password_sync_enabled(true);
EXPECT_FALSE(IsGenerationEnabled());
}
@@ -160,7 +160,7 @@ TEST_F(PasswordGenerationManagerTest, IsGenerationEnabled) {
TEST_F(PasswordGenerationManagerTest, DetectAccountCreationForms) {
// Setup so that IsGenerationEnabled() returns true.
PrefService* prefs = client_->GetPrefs();
- prefs->SetBoolean(prefs::kPasswordManagerEnabled, true);
+ prefs->SetBoolean(prefs::kPasswordManagerSavingEnabled, true);
client_->set_is_password_sync_enabled(true);
autofill::FormData login_form;
@@ -214,7 +214,7 @@ TEST_F(PasswordGenerationManagerTest, UpdatePasswordSyncStateIncognito) {
// be disabled.
GetTestDriver()->set_is_off_the_record(true);
PrefService* prefs = client_->GetPrefs();
- prefs->SetBoolean(prefs::kPasswordManagerEnabled, true);
+ prefs->SetBoolean(prefs::kPasswordManagerSavingEnabled, true);
client_->set_is_password_sync_enabled(true);
EXPECT_FALSE(IsGenerationEnabled());

Powered by Google App Engine
This is Rietveld 408576698