chrome/browser/extensions/api/preference/preference_apitest.cc - Issue 380713003: PasswordManager - update "password_manager_enabled_" pref name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/preference_apitest.cc

Issue 380713003: PasswordManager - update "password_manager_enabled_" pref name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Trybots failure (rebase was needed) Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.cc ('k') | chrome/browser/policy/configuration_policy_handler_list_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/preference_apitest.cc

diff --git a/chrome/browser/extensions/api/preference/preference_apitest.cc b/chrome/browser/extensions/api/preference/preference_apitest.cc

index 29fdcbc62bdca429eb8be7a55e6dd61b9ef609e4..618e8dac9ce3f7f6d89b6cb5c2ebe17808ed86f4 100644

--- a/chrome/browser/extensions/api/preference/preference_apitest.cc

+++ b/chrome/browser/extensions/api/preference/preference_apitest.cc

@@ -44,7 +44,7 @@ class ExtensionPreferenceApiTest : public ExtensionApiTest {

EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableTranslate));

EXPECT_TRUE(prefs->GetBoolean(prefs::kNetworkPredictionEnabled));

EXPECT_TRUE(prefs->GetBoolean(

- password_manager::prefs::kPasswordManagerEnabled));

+ password_manager::prefs::kPasswordManagerSavingEnabled));

EXPECT_TRUE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled));

EXPECT_TRUE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));

}

@@ -63,7 +63,7 @@ class ExtensionPreferenceApiTest : public ExtensionApiTest {

EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableTranslate));

EXPECT_FALSE(prefs->GetBoolean(prefs::kNetworkPredictionEnabled));

EXPECT_FALSE(prefs->GetBoolean(

- password_manager::prefs::kPasswordManagerEnabled));

+ password_manager::prefs::kPasswordManagerSavingEnabled));

EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled));

EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));

}

@@ -109,7 +109,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionPreferenceApiTest, MAYBE_Standard) {

prefs->SetBoolean(prefs::kEnableReferrers, false);

prefs->SetBoolean(prefs::kEnableTranslate, false);

prefs->SetBoolean(prefs::kNetworkPredictionEnabled, false);

- prefs->SetBoolean(password_manager::prefs::kPasswordManagerEnabled, false);

+ prefs->SetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled,

+ false);

prefs->SetBoolean(prefs::kSafeBrowsingEnabled, false);

prefs->SetBoolean(prefs::kSearchSuggestEnabled, false);