PasswordManager - update "password_manager_enabled_" pref name

components/password_manager/core/common/password_manager_pref_names.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/common/password_manager_pref_names.h"
 
 namespace password_manager {
 
 namespace prefs {
 
 #if defined(OS_WIN)
 // Whether the password was blank, only valid if OS password was last changed
 // on or before the value contained in kOsPasswordLastChanged.
 const char kOsPasswordBlank[] = "password_manager.os_password_blank";
 
 // The number of seconds since epoch that the OS password was last changed.
 const char kOsPasswordLastChanged[] =
     "password_manager.os_password_last_changed";
 #endif
 
 // Boolean controlling whether the password manager allows to retrieve passwords
 // in clear text.
 const char kPasswordManagerAllowShowPasswords[] =
     "profile.password_manager_allow_show_passwords";
 
-// Boolean that is true if the password manager is on (will record new
-// passwords and fill in known passwords).
-const char kPasswordManagerEnabled[] = "profile.password_manager_enabled";
+// Boolean that is true if password saving is on (will record new
+// passwords and fill in known passwords). When it is false, it doesn't
+// ask if you want to save passwords but will continue to fill passwords.
+// See http://crbug.com/392387

[vabr (Chromium), 2014/07/10 08:36:54]

nit: Please also explain the difference in the constant name and value.
Something like:
"The constant value (=setting name) differs from its name for historical
reasons; making the setting name match the constant name was not deemed
important enough to justify adding migration code for that."

[Nikhil, 2014/07/10 09:56:35]

Done.

+const char kPasswordManagerSavingEnabled[] = "profile.password_manager_enabled";
 
 // A list of numbers. Each number corresponds to one of the domains monitored
 // for save-password-prompt breakages. That number is a random index into
 // the array of groups containing the monitored domain. That group should be
 // used for reporting that domain.
 const char kPasswordManagerGroupsForDomains[] =
     "profile.password_manager_groups_for_domains";
 
 #if !defined(OS_MACOSX) && !defined(OS_CHROMEOS) && defined(OS_POSIX)
 // The local profile id for this profile.
 const char kLocalProfileId[] = "profile.local_profile_id";
 #endif
 
 }  // namespace prefs
 
 }  // namespace password_manager