Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc

Issue 380713003: PasswordManager - update "password_manager_enabled_" pref name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/values.h" 5 #include "base/values.h"
6 #include "chrome/browser/sync/test/integration/preferences_helper.h" 6 #include "chrome/browser/sync/test/integration/preferences_helper.h"
7 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h" 7 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
8 #include "chrome/browser/sync/test/integration/sync_integration_test_util.h" 8 #include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
9 #include "chrome/browser/sync/test/integration/sync_test.h" 9 #include "chrome/browser/sync/test/integration/sync_test.h"
10 #include "chrome/browser/translate/chrome_translate_client.h" 10 #include "chrome/browser/translate/chrome_translate_client.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 ASSERT_TRUE(StringPrefMatches(prefs::kHomePage)); 65 ASSERT_TRUE(StringPrefMatches(prefs::kHomePage));
66 66
67 ChangeStringPref(0, prefs::kHomePage, "http://www.google.com/0"); 67 ChangeStringPref(0, prefs::kHomePage, "http://www.google.com/0");
68 ChangeStringPref(1, prefs::kHomePage, "http://www.google.com/1"); 68 ChangeStringPref(1, prefs::kHomePage, "http://www.google.com/1");
69 ASSERT_TRUE(AwaitQuiescence()); 69 ASSERT_TRUE(AwaitQuiescence());
70 ASSERT_TRUE(StringPrefMatches(prefs::kHomePage)); 70 ASSERT_TRUE(StringPrefMatches(prefs::kHomePage));
71 } 71 }
72 72
73 // TCM ID - 3649278. 73 // TCM ID - 3649278.
74 IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest, 74 IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest,
75 kPasswordManagerEnabled) { 75 kPasswordManagerSavingEnabled) {
76 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 76 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
77 ASSERT_TRUE( 77 ASSERT_TRUE(BooleanPrefMatches(
78 BooleanPrefMatches(password_manager::prefs::kPasswordManagerEnabled)); 78 password_manager::prefs::kPasswordManagerSavingEnabled));
79 79
80 ChangeBooleanPref(0, password_manager::prefs::kPasswordManagerEnabled); 80 ChangeBooleanPref(0, password_manager::prefs::kPasswordManagerSavingEnabled);
81 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 81 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
82 ASSERT_TRUE( 82 ASSERT_TRUE(BooleanPrefMatches(
83 BooleanPrefMatches(password_manager::prefs::kPasswordManagerEnabled)); 83 password_manager::prefs::kPasswordManagerSavingEnabled));
84 } 84 }
85 85
86 // TCM ID - 3699293. 86 // TCM ID - 3699293.
87 IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest, 87 IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest,
88 kSyncKeepEverythingSynced) { 88 kSyncKeepEverythingSynced) {
89 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 89 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
90 DisableVerifier(); 90 DisableVerifier();
91 91
92 ASSERT_TRUE( 92 ASSERT_TRUE(
93 BooleanPrefMatches(sync_driver::prefs::kSyncKeepEverythingSynced)); 93 BooleanPrefMatches(sync_driver::prefs::kSyncKeepEverythingSynced));
94 ASSERT_TRUE(BooleanPrefMatches(sync_driver::prefs::kSyncThemes)); 94 ASSERT_TRUE(BooleanPrefMatches(sync_driver::prefs::kSyncThemes));
95 95
96 GetClient(0)->DisableSyncForDatatype(syncer::THEMES); 96 GetClient(0)->DisableSyncForDatatype(syncer::THEMES);
97 ASSERT_FALSE( 97 ASSERT_FALSE(
98 BooleanPrefMatches(sync_driver::prefs::kSyncKeepEverythingSynced)); 98 BooleanPrefMatches(sync_driver::prefs::kSyncKeepEverythingSynced));
99 } 99 }
100 100
101 // TCM ID - 3661290. 101 // TCM ID - 3661290.
102 IN_PROC_BROWSER_TEST_F(LegacyTwoClientPreferencesSyncTest, DisablePreferences) { 102 IN_PROC_BROWSER_TEST_F(LegacyTwoClientPreferencesSyncTest, DisablePreferences) {
103 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 103 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
104 DisableVerifier(); 104 DisableVerifier();
105 105
106 ASSERT_TRUE(BooleanPrefMatches(sync_driver::prefs::kSyncPreferences)); 106 ASSERT_TRUE(BooleanPrefMatches(sync_driver::prefs::kSyncPreferences));
107 ASSERT_TRUE( 107 ASSERT_TRUE(BooleanPrefMatches(
108 BooleanPrefMatches(password_manager::prefs::kPasswordManagerEnabled)); 108 password_manager::prefs::kPasswordManagerSavingEnabled));
109 109
110 GetClient(1)->DisableSyncForDatatype(syncer::PREFERENCES); 110 GetClient(1)->DisableSyncForDatatype(syncer::PREFERENCES);
111 ChangeBooleanPref(0, password_manager::prefs::kPasswordManagerEnabled); 111 ChangeBooleanPref(0, password_manager::prefs::kPasswordManagerSavingEnabled);
112 ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService((0)))); 112 ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService((0))));
113 ASSERT_FALSE( 113 ASSERT_FALSE(BooleanPrefMatches(
114 BooleanPrefMatches(password_manager::prefs::kPasswordManagerEnabled)); 114 password_manager::prefs::kPasswordManagerSavingEnabled));
115 115
116 GetClient(1)->EnableSyncForDatatype(syncer::PREFERENCES); 116 GetClient(1)->EnableSyncForDatatype(syncer::PREFERENCES);
117 ASSERT_TRUE(AwaitQuiescence()); 117 ASSERT_TRUE(AwaitQuiescence());
118 ASSERT_TRUE( 118 ASSERT_TRUE(BooleanPrefMatches(
119 BooleanPrefMatches(password_manager::prefs::kPasswordManagerEnabled)); 119 password_manager::prefs::kPasswordManagerSavingEnabled));
120 } 120 }
121 121
122 // TCM ID - 3664292. 122 // TCM ID - 3664292.
123 IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest, DisableSync) { 123 IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest, DisableSync) {
124 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 124 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
125 DisableVerifier(); 125 DisableVerifier();
126 126
127 ASSERT_TRUE(BooleanPrefMatches(sync_driver::prefs::kSyncPreferences)); 127 ASSERT_TRUE(BooleanPrefMatches(sync_driver::prefs::kSyncPreferences));
128 ASSERT_TRUE( 128 ASSERT_TRUE(BooleanPrefMatches(
129 BooleanPrefMatches(password_manager::prefs::kPasswordManagerEnabled)); 129 password_manager::prefs::kPasswordManagerSavingEnabled));
130 ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton)); 130 ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton));
131 131
132 GetClient(1)->DisableSyncForAllDatatypes(); 132 GetClient(1)->DisableSyncForAllDatatypes();
133 ChangeBooleanPref(0, password_manager::prefs::kPasswordManagerEnabled); 133 ChangeBooleanPref(0, password_manager::prefs::kPasswordManagerSavingEnabled);
134 ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService((0)))); 134 ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService((0))));
135 ASSERT_FALSE( 135 ASSERT_FALSE(BooleanPrefMatches(
136 BooleanPrefMatches(password_manager::prefs::kPasswordManagerEnabled)); 136 password_manager::prefs::kPasswordManagerSavingEnabled));
137 137
138 ChangeBooleanPref(1, prefs::kShowHomeButton); 138 ChangeBooleanPref(1, prefs::kShowHomeButton);
139 ASSERT_FALSE(BooleanPrefMatches(prefs::kShowHomeButton)); 139 ASSERT_FALSE(BooleanPrefMatches(prefs::kShowHomeButton));
140 140
141 GetClient(1)->EnableSyncForAllDatatypes(); 141 GetClient(1)->EnableSyncForAllDatatypes();
142 ASSERT_TRUE(AwaitQuiescence()); 142 ASSERT_TRUE(AwaitQuiescence());
143 ASSERT_TRUE( 143 ASSERT_TRUE(BooleanPrefMatches(
144 BooleanPrefMatches(password_manager::prefs::kPasswordManagerEnabled)); 144 password_manager::prefs::kPasswordManagerSavingEnabled));
145 ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton)); 145 ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton));
146 } 146 }
147 147
148 // TCM ID - 3604297. 148 // TCM ID - 3604297.
149 IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest, SignInDialog) { 149 IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest, SignInDialog) {
150 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 150 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
151 DisableVerifier(); 151 DisableVerifier();
152 152
153 ASSERT_TRUE(BooleanPrefMatches(sync_driver::prefs::kSyncPreferences)); 153 ASSERT_TRUE(BooleanPrefMatches(sync_driver::prefs::kSyncPreferences));
154 ASSERT_TRUE(BooleanPrefMatches(sync_driver::prefs::kSyncBookmarks)); 154 ASSERT_TRUE(BooleanPrefMatches(sync_driver::prefs::kSyncBookmarks));
(...skipping 455 matching lines...) Expand 10 before | Expand all | Expand 10 after
610 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 610 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
611 ASSERT_TRUE(IsEncryptionComplete(0)); 611 ASSERT_TRUE(IsEncryptionComplete(0));
612 ASSERT_TRUE(IsEncryptionComplete(1)); 612 ASSERT_TRUE(IsEncryptionComplete(1));
613 ASSERT_TRUE(BooleanPrefMatches(prefs::kHomePageIsNewTabPage)); 613 ASSERT_TRUE(BooleanPrefMatches(prefs::kHomePageIsNewTabPage));
614 614
615 ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton)); 615 ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton));
616 ChangeBooleanPref(0, prefs::kShowHomeButton); 616 ChangeBooleanPref(0, prefs::kShowHomeButton);
617 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 617 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
618 ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton)); 618 ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton));
619 } 619 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698