Profile picture doesn't display correctly after new profile has been created

chrome/browser/profiles/profile_info_cache.cc

Index: chrome/browser/profiles/profile_info_cache.cc
diff --git a/chrome/browser/profiles/profile_info_cache.cc b/chrome/browser/profiles/profile_info_cache.cc
index a6f8d9abb02caa453cd2642ea2aa49105abb51bc..3caf2edc6e557ee10ab183cb32c769564b3dcd9b 100644
--- a/chrome/browser/profiles/profile_info_cache.cc
+++ b/chrome/browser/profiles/profile_info_cache.cc
@@ -233,6 +233,9 @@ void ProfileInfoCache::AddProfileToCache(
                     observer_list_,
                     OnProfileAdded(profile_path));
 
+  if (switches::IsNewAvatarMenu())

[noms (inactive), 2014/07/11 13:47:56]

I'm sorry, I didn't see this initially because the code was hidden. Could you
move this above the OnProfileAdded notification? Basically, the notifications
should only be sent out once we've done all the work.

[Malcolm, 2014/07/11 14:18:44]

You are right, this should be done before notification is sent out. Also, I have
think about a solution to make the failed test pass, just declare the method
like:
void ProfileInfoCache::AddProfileToCache(
    const base::FilePath& profile_path,
    const base::string16& name,
    const base::string16& username,
    size_t icon_index,
    const std::string& supervised_user_id,
    bool willDownloadResAvatar = true); 

then in the ProfileInfoCacheTest.DownloadHighResAvatarTest call like below:
  GetCache()->AddProfileToCache(path_1, ASCIIToUTF16("name_1"),
                                base::string16(), 0, std::string(), false);

This will not break the current code and make the test work fine. What's your
suggestion?

On 2014/07/11 13:47:56, Monica Dinculescu wrote:

[noms (inactive), 2014/07/11 15:59:11]

Default arguments are not allowed in Chromium, unfortunately. I will take a look
at the ProfileInfoCache today and see whether this call can be moved somewhere
else, or mocked out in tests.

On 2014/07/11 14:18:44, Malcolm wrote:

+    DownloadHighResAvatar(icon_index, profile_path);
+
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_PROFILE_CACHED_INFO_CHANGED,
       content::NotificationService::AllSources(),