ui/app_list/views/app_list_background.cc - Issue 380613002: Experimental app list: Added a current page indicator to the launcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/views/app_list_background.cc

Issue 380613002: Experimental app list: Added a current page indicator to the launcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/app_list/views/app_list_background.cc

diff --git a/ui/app_list/views/app_list_background.cc b/ui/app_list/views/app_list_background.cc

index 19085e60bb3892675ad004f109971f9485b4d355..e36f82d42198759d826d4623994106d3d86a5922 100644

--- a/ui/app_list/views/app_list_background.cc

+++ b/ui/app_list/views/app_list_background.cc

@@ -88,7 +88,9 @@ void AppListBackground::Paint(gfx::Canvas* canvas,

const gfx::Rect contents_view_view_bounds =

contents_view->ConvertRectToWidget(contents_view->GetLocalBounds());

gfx::Rect separator_rect(contents_rect);

- separator_rect.set_y(contents_view_view_bounds.bottom());

+ // Extra 1 pixel so the launcher page indicator overlays the

+ // separator rect.

calamity 2014/07/09 05:50:18 nit: 'separator' can wrap to the previous line.

kcarattini 2014/07/09 06:45:21 Done.

+ separator_rect.set_y(contents_view_view_bounds.bottom() + 1);

separator_rect.set_height(kBottomSeparatorSize);

canvas->FillRect(separator_rect, kBottomSeparatorColor);

int contents_switcher_top = separator_rect.bottom();

« no previous file with comments | « no previous file | ui/app_list/views/contents_switcher_view.h » ('j') | ui/app_list/views/contents_switcher_view.cc » ('J')