Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 380603002: Update Memory.RendererUsed only after Blink is initialized (Closed)

Created:
6 years, 5 months ago by kouhei (in TOK)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, haraken, jam
Project:
chromium
Visibility:
Public.

Description

Update Memory.RendererUsed only after Blink is initialized Yak shaving to land https://codereview.chromium.org/380533003/ Before the patch, |MemoryObserver| called |GetMemoryUsageKB()| without any check, which is only valid after webkit is initialized. GetMemoryUsageKB queries |v8::Isolate::GetCurrent()| internally, but the query fails on DCHECK on debug builds. This patch moves the |MemoryObserver| instantiation inside |RenderThreadImpl::EnsureWebKitInitialized|. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282321

Patch Set 1 #

Patch Set 2 : Instantiate MemoryObserver from EnsureWebKitInitialized #

Patch Set 3 : remove observer at exit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -23 lines) Patch
M content/renderer/render_thread_impl.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 4 chunks +28 lines, -0 lines 0 comments Download
M content/renderer/renderer_main.cc View 1 3 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kouhei (in TOK)
jochen: Would you take a look?
6 years, 5 months ago (2014-07-09 04:55:04 UTC) #1
jochen (gone - plz use gerrit)
On 2014/07/09 at 04:55:04, kouhei wrote: > jochen: Would you take a look? why not ...
6 years, 5 months ago (2014-07-09 09:16:17 UTC) #2
kouhei (in TOK)
On 2014/07/09 09:16:17, jochen wrote: > On 2014/07/09 at 04:55:04, kouhei wrote: > > jochen: ...
6 years, 5 months ago (2014-07-09 09:45:34 UTC) #3
jochen (gone - plz use gerrit)
On 2014/07/09 at 09:45:34, kouhei wrote: > On 2014/07/09 09:16:17, jochen wrote: > > On ...
6 years, 5 months ago (2014-07-09 09:50:01 UTC) #4
kouhei (in TOK)
On 2014/07/09 09:50:01, jochen wrote: > On 2014/07/09 at 09:45:34, kouhei wrote: > > On ...
6 years, 5 months ago (2014-07-10 05:41:59 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-10 11:19:58 UTC) #6
kouhei (in TOK)
Thanks for review!
6 years, 5 months ago (2014-07-10 11:28:09 UTC) #7
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 5 months ago (2014-07-10 11:28:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/380603002/40001
6 years, 5 months ago (2014-07-10 11:29:01 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 12:52:58 UTC) #10
Message was sent while issue was closed.
Change committed as 282321

Powered by Google App Engine
This is Rietveld 408576698