Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3827)

Unified Diff: chrome/browser/autofill/autofill_profile.h

Issue 3806008: Never allow empty preview entries. As some data is always present (we drop co... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_dialog_gtk.cc ('k') | chrome/browser/autofill/autofill_profile.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_profile.h
===================================================================
--- chrome/browser/autofill/autofill_profile.h (revision 63786)
+++ chrome/browser/autofill/autofill_profile.h (working copy)
@@ -46,6 +46,9 @@
// Returns a copy of the profile it is called on. The caller is responsible
// for deleting profile when they are done with it.
virtual FormGroup* Clone() const;
+ // The user-visible label of the profile, generated in relation to other
+ // profiles. Shows at least 2 fields that differentiate profile from other
+ // profiles. See AdjustInferredLabels() further down for more description.
virtual const string16& Label() const;
int unique_id() const { return unique_id_; }
@@ -55,16 +58,6 @@
const std::string guid() const { return guid_; }
void set_guid(const std::string& guid) { guid_ = guid; }
- // Profile summary string for UI.
- // Constructs a summary string based on NAME_FIRST, NAME_LAST, and
- // ADDRESS_HOME_LINE1 fields of the profile. The summary string is of the
- // form:
- // L"<first_name> <last_name>, <address_line_1>"
- // but may omit any or all of the fields if they are not present in the
- // profile.
- // The form of the string is governed by generated resources.
- string16 PreviewSummary() const;
-
// Adjusts the labels according to profile data.
// Labels contain minimal different combination of:
// 1. Full name.
« no previous file with comments | « chrome/browser/autofill/autofill_dialog_gtk.cc ('k') | chrome/browser/autofill/autofill_profile.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698