Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 380573002: Turn on clang by default on linux, 2nd try. (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
Reviewers:
awong, eseidel
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, Dai Mikurube (NOT FULLTIME), ukai+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Turn on clang by default on linux, 2nd try. This is mostly to collect performance and size data for now. Unless things look really good, I'm going to revert this by wednesday morning (PDT). BUG=360311 TBR=awong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M build/common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/clang/scripts/update.sh View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
6 years, 5 months ago (2014-07-09 01:48:02 UTC) #1
Nico
Committed patchset #1 manually as r281914 (presubmit successful).
6 years, 5 months ago (2014-07-09 04:03:31 UTC) #2
Nico
A revert of this CL has been created in https://codereview.chromium.org/379083002/ by thakis@chromium.org. The reason for ...
6 years, 5 months ago (2014-07-09 04:29:46 UTC) #3
eseidel
This may also ahve caused https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/51022/steps/compile/logs/stdio ?
6 years, 5 months ago (2014-07-09 05:38:49 UTC) #4
Nico
On Tue, Jul 8, 2014 at 10:38 PM, <eseidel@chromium.org> wrote: > This may also ahve ...
6 years, 5 months ago (2014-07-09 15:56:42 UTC) #5
Nico
s/awong/ajwong/
6 years, 5 months ago (2014-07-09 15:57:10 UTC) #6
awong
6 years, 5 months ago (2014-07-09 15:59:50 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698