Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: ui/base/clipboard/clipboard_util_win.h

Issue 380553002: Add a unit test that filenames aren't unintentionally converted to URLs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/clipboard_win.cc ('k') | ui/base/clipboard/clipboard_util_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/clipboard/clipboard_util_win.h
diff --git a/ui/base/clipboard/clipboard_util_win.h b/ui/base/clipboard/clipboard_util_win.h
index 12e668f079e0abae86939b369a655cbfa7588920..c2171da5f16b636663025bf2e3ae06a3ba145ea0 100644
--- a/ui/base/clipboard/clipboard_util_win.h
+++ b/ui/base/clipboard/clipboard_util_win.h
@@ -15,6 +15,8 @@
#include "base/strings/string16.h"
#include "ui/base/ui_base_export.h"
+class GURL;
+
namespace ui {
class UI_BASE_EXPORT ClipboardUtil {
@@ -31,8 +33,10 @@ class UI_BASE_EXPORT ClipboardUtil {
/////////////////////////////////////////////////////////////////////////////
// Helper methods to extract information from an IDataObject. These methods
// return true if the requested data type is found in |data_object|.
+
+ // Only returns true if url->is_valid() is true.
static bool GetUrl(IDataObject* data_object,
- base::string16* url,
+ GURL* url,
base::string16* title,
bool convert_filenames);
static bool GetFilenames(IDataObject* data_object,
« no previous file with comments | « remoting/host/clipboard_win.cc ('k') | ui/base/clipboard/clipboard_util_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698