printing/backend/print_backend_win.cc - Issue 380553002: Add a unit test that filenames aren't unintentionally converted to URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/backend/print_backend_win.cc

Issue 380553002: Add a unit test that filenames aren't unintentionally converted to URLs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: printing/backend/print_backend_win.cc

diff --git a/printing/backend/print_backend_win.cc b/printing/backend/print_backend_win.cc

index a8139f397e069fef04bba3c6d7dc3c7350723eaa..d56ee60e312a813fb31de080b9253d4141144d3f 100644

--- a/printing/backend/print_backend_win.cc

+++ b/printing/backend/print_backend_win.cc

@@ -30,7 +30,7 @@ HRESULT StreamOnHGlobalToString(IStream* stream, std::string* out) {

HRESULT hr = GetHGlobalFromStream(stream, &hdata);

if (SUCCEEDED(hr)) {

DCHECK(hdata);

- base::win::ScopedHGlobal<char> locked_data(hdata);

+ base::win::ScopedHGlobal<char*> locked_data(hdata);

out->assign(locked_data.release(), locked_data.Size());

}

return hr;

« no previous file with comments | « base/win/scoped_hglobal.h ('k') | remoting/host/clipboard_win.cc » ('j') | no next file with comments »