Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: net/quic/test_tools/crypto_test_utils.h

Issue 380543003: Add an async ChannelIDSource for testing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Improve comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/test_tools/crypto_test_utils.h
diff --git a/net/quic/test_tools/crypto_test_utils.h b/net/quic/test_tools/crypto_test_utils.h
index cc16d4699b627fee761a420ba1ba3ff7acbc7668..acc687944080f3122e53e36b7924cbb7adad5923 100644
--- a/net/quic/test_tools/crypto_test_utils.h
+++ b/net/quic/test_tools/crypto_test_utils.h
@@ -38,6 +38,15 @@ class PacketSavingConnection;
class CryptoTestUtils {
public:
+ // An interface for a source of tasks to run.
Ryan Hamilton 2014/07/09 16:54:39 This is a very generic description. Can you add co
wtc 2014/07/09 19:44:42 Done. Added more comments. Also renamed this class
+ class TaskSource {
+ public:
+ virtual ~TaskSource() {}
+
+ // Runs all pending tasks in this source.
+ virtual void RunPending() = 0;
+ };
+
// FakeClientOptions bundles together a number of options for configuring
// HandshakeWithFakeClient.
struct FakeClientOptions {
@@ -50,6 +59,10 @@ class CryptoTestUtils {
// If channel_id_enabled is true then the client will attempt to send a
// ChannelID.
bool channel_id_enabled;
+
+ // If channel_id_source_async is true then the client will use an async
+ // ChannelIDSource for testing. Ignored if channel_id_enabled is false.
+ bool channel_id_source_async;
};
// returns: the number of client hellos that the client sent.
@@ -69,12 +82,13 @@ class CryptoTestUtils {
QuicConfig* config,
QuicCryptoServerConfig* crypto_config);
- // CommunicateHandshakeMessages moves messages from |a| to |b| and back until
- // |a|'s handshake has completed.
+ // CommunicateHandshakeMessages moves messages from |a| to |b| and back and
+ // runs pending tasks in |task_source| until |a|'s handshake has completed.
static void CommunicateHandshakeMessages(PacketSavingConnection* a_conn,
QuicCryptoStream* a,
PacketSavingConnection* b_conn,
- QuicCryptoStream* b);
+ QuicCryptoStream* b,
+ TaskSource* task_source = NULL);
// AdvanceHandshake attempts to moves messages from |a| to |b| and |b| to |a|.
// Returns the number of messages moved.

Powered by Google App Engine
This is Rietveld 408576698