Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 380533003: Flush form cache when next document is loaded to avoid Document leak. (Closed)

Created:
6 years, 5 months ago by kouhei (in TOK)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Flush form cache when next document is loaded to avoid Document leak. This should fix a document leak from r270279. BUG=392121 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282524

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M components/autofill/content/renderer/autofill_agent.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_memory_unittest.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kouhei (in TOK)
Would you take a look?
6 years, 5 months ago (2014-07-09 01:10:40 UTC) #1
kouhei (in TOK)
Looking at bot failures. I think their baseline is wrong (testing that there are 2 ...
6 years, 5 months ago (2014-07-09 02:31:01 UTC) #2
please use gerrit instead
On 2014/07/09 02:31:01, kouhei wrote: > Looking at bot failures. I think their baseline is ...
6 years, 5 months ago (2014-07-09 02:41:36 UTC) #3
kouhei (in TOK)
I think we can rebaseline the DOM count, we fixed a leak in this CL ...
6 years, 5 months ago (2014-07-09 06:28:33 UTC) #4
Ilya Sherman
Autofill changes LGTM. Thanks!
6 years, 5 months ago (2014-07-09 06:40:09 UTC) #5
kouhei (in TOK)
Thanks! nduca: Would you take a look at telemetry rebaseline?
6 years, 5 months ago (2014-07-09 06:41:45 UTC) #6
nduca
telemetry lgtm
6 years, 5 months ago (2014-07-10 18:01:43 UTC) #7
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 5 months ago (2014-07-11 00:20:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/380533003/20001
6 years, 5 months ago (2014-07-11 00:22:08 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 03:18:31 UTC) #10
Message was sent while issue was closed.
Change committed as 282524

Powered by Google App Engine
This is Rietveld 408576698