Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: mojo/services/surfaces/surfaces_impl.h

Issue 380413003: Mojo: Use InterfaceFactory<Interface> for service registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: specify ownership in the Bind call Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/surfaces/surfaces_impl.h
diff --git a/mojo/services/surfaces/surfaces_impl.h b/mojo/services/surfaces/surfaces_impl.h
index 5ecb9cf57ddfa1554848afbf615d38de7e115846..21f2daab0298826e7fa9a2647bc76c9e038d35e8 100644
--- a/mojo/services/surfaces/surfaces_impl.h
+++ b/mojo/services/surfaces/surfaces_impl.h
@@ -28,14 +28,15 @@ class SurfacesImpl : public InterfaceImpl<Surface>,
public cc::SurfaceFactoryClient,
public cc::DisplayClient {
public:
- class Context {
+ class Client {
public:
- virtual cc::SurfaceManager* Manager() = 0;
- virtual uint32_t IdNamespace() = 0;
virtual void FrameSubmitted() = 0;
virtual void SetDisplay(cc::Display*) = 0;
};
- SurfacesImpl(ApplicationConnection* app, Context* context);
+
+ SurfacesImpl(cc::SurfaceManager* manager,
+ uint32_t id_namespace,
DaveMoore 2014/07/15 00:08:29 Are these changes related to this cl?
jamesr 2014/07/15 00:33:10 Yes, using InterfaceProvider allows greatly simpli
+ Client* client);
virtual ~SurfacesImpl();
// InterfaceImpl<Surface> implementation.
@@ -59,9 +60,10 @@ class SurfacesImpl : public InterfaceImpl<Surface>,
cc::SurfaceFactory* factory() { return &factory_; }
private:
- Context* context_;
+ cc::SurfaceManager* manager_;
cc::SurfaceFactory factory_;
uint32_t id_namespace_;
+ Client* client_;
scoped_ptr<cc::Display> display_;
ScopedMessagePipeHandle command_buffer_handle_;

Powered by Google App Engine
This is Rietveld 408576698