Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Unified Diff: mojo/public/cpp/bindings/tests/handle_passing_unittest.cc

Issue 380413003: Mojo: Use InterfaceFactory<Interface> for service registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix network_service_loader Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/handle_passing_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc b/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc
index d2e287f73dfc2df260cd02fd1688074cc4962ebe..696e6135fe63fe25794791b93292cf9a96629942 100644
--- a/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc
@@ -29,10 +29,6 @@ class StringRecorder {
class ImportedInterfaceImpl
: public InterfaceImpl<imported::ImportedInterface> {
public:
- virtual void OnConnectionError() MOJO_OVERRIDE {
- delete this;
- }
-
virtual void DoSomething() MOJO_OVERRIDE {
do_something_count_++;
}
@@ -46,10 +42,6 @@ int ImportedInterfaceImpl::do_something_count_ = 0;
class SampleNamedObjectImpl : public InterfaceImpl<sample::NamedObject> {
public:
- virtual void OnConnectionError() MOJO_OVERRIDE {
- delete this;
- }
-
virtual void SetName(const mojo::String& name) MOJO_OVERRIDE {
name_ = name;
}
@@ -65,10 +57,6 @@ class SampleNamedObjectImpl : public InterfaceImpl<sample::NamedObject> {
class SampleFactoryImpl : public InterfaceImpl<sample::Factory> {
public:
- virtual void OnConnectionError() MOJO_OVERRIDE {
- delete this;
- }
-
virtual void DoStuff(sample::RequestPtr request,
ScopedMessagePipeHandle pipe) MOJO_OVERRIDE {
std::string text1;
« no previous file with comments | « mojo/public/cpp/bindings/lib/interface_impl_internal.h ('k') | mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698