mojo/services/view_manager/root_node_manager.cc - Issue 380413003: Mojo: Use InterfaceFactory<Interface> for service registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/root_node_manager.cc

Issue 380413003: Mojo: Use InterfaceFactory<Interface> for service registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix message loop destruction order Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/view_manager/root_node_manager.cc

diff --git a/mojo/services/view_manager/root_node_manager.cc b/mojo/services/view_manager/root_node_manager.cc

index fe608e822fe27411cc13b40d83343c9a4f01060e..99f8ccf866077d55c45d05bb6cef00e6c013a5fc 100644

--- a/mojo/services/view_manager/root_node_manager.cc

+++ b/mojo/services/view_manager/root_node_manager.cc

@@ -261,7 +261,7 @@ ViewManagerServiceImpl* RootNodeManager::EmbedImpl(

creator_url,

url.To<std::string>(),

root_id);

- BindToPipe(connection, pipe.handle0.Pass());

+ WeakBindToPipe(connection, pipe.handle0.Pass());

connections_created_by_connect_.insert(connection);

OnConnectionMessagedClient(connection->id());

return connection;