mojo/services/network/url_loader_impl.cc - Issue 380413003: Mojo: Use InterfaceFactory<Interface> for service registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/network/url_loader_impl.cc

Issue 380413003: Mojo: Use InterfaceFactory<Interface> for service registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review feedback Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/network/url_loader_impl.cc

diff --git a/mojo/services/network/url_loader_impl.cc b/mojo/services/network/url_loader_impl.cc

index fe490ab36933037c00c3cd779a3bc4eb1be7334f..465fb6a04ba353a4307d3d52f88b57ac8bff0cc3 100644

--- a/mojo/services/network/url_loader_impl.cc

+++ b/mojo/services/network/url_loader_impl.cc

@@ -118,10 +118,6 @@ URLLoaderImpl::URLLoaderImpl(NetworkContext* context)

URLLoaderImpl::~URLLoaderImpl() {

}

-void URLLoaderImpl::OnConnectionError() {

- delete this;

void URLLoaderImpl::Start(URLRequestPtr request,

const Callback<void(URLResponsePtr)>& callback) {

if (url_request_) {