mojo/service_manager/service_manager.cc - Issue 380413003: Mojo: Use InterfaceFactory<Interface> for service registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/service_manager/service_manager.cc

Issue 380413003: Mojo: Use InterfaceFactory<Interface> for service registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review feedback Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/service_manager/service_manager.cc

diff --git a/mojo/service_manager/service_manager.cc b/mojo/service_manager/service_manager.cc

index 65a93bdf68d03074b45ba64151f52cb4cfe3ea75..7a5e53c5033b4a11f04302de34d867b47ee30582 100644

--- a/mojo/service_manager/service_manager.cc

+++ b/mojo/service_manager/service_manager.cc

@@ -115,7 +115,7 @@ void ServiceManager::ConnectToApplication(const GURL& url,

} else {

MessagePipe pipe;

GetLoaderForURL(url)->LoadService(this, url, pipe.handle0.Pass());

- shell_impl = BindToPipe(new ShellImpl(this, url), pipe.handle1.Pass());

+ shell_impl = WeakBindToPipe(new ShellImpl(this, url), pipe.handle1.Pass());

url_to_shell_impl_[url] = shell_impl;

}

if (interceptor_) {