Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Unified Diff: mojo/services/surfaces/surfaces_service_application.h

Issue 380413003: Mojo: Use InterfaceFactory<Interface> for service registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: convert everything over, remove ApplicationConnection::AddService Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/surfaces/surfaces_service_application.h
diff --git a/mojo/services/surfaces/surfaces_service_application.h b/mojo/services/surfaces/surfaces_service_application.h
index ac6820dc400a6a323de5ba89d15d57fc9360757e..896ac68f49a12b951ff4eebf9520ed28a4484b28 100644
--- a/mojo/services/surfaces/surfaces_service_application.h
+++ b/mojo/services/surfaces/surfaces_service_application.h
@@ -14,9 +14,11 @@ namespace mojo {
class ApplicationConnection;
namespace surfaces {
+class Surfaces;
darin (slow to review) 2014/07/15 06:10:38 nit: looks like this forward decl isn't needed.
class SurfacesServiceApplication : public ApplicationDelegate,
- public SurfacesImpl::Context {
+ public InterfaceFactory<Surface>,
+ public SurfacesImpl::Client {
public:
SurfacesServiceApplication();
virtual ~SurfacesServiceApplication();
@@ -25,9 +27,11 @@ class SurfacesServiceApplication : public ApplicationDelegate,
virtual bool ConfigureIncomingConnection(
ApplicationConnection* connection) OVERRIDE;
- // SurfacesImpl::Context implementation.
- virtual cc::SurfaceManager* Manager() OVERRIDE;
- virtual uint32_t IdNamespace() OVERRIDE;
+ // InterfaceFactory<Surface> implementation.
+ virtual void Create(ApplicationConnection* connection,
+ InterfaceRequest<Surface> request) OVERRIDE;
+
+ // SurfacesImpl::Client implementation.
virtual void FrameSubmitted() OVERRIDE;
virtual void SetDisplay(cc::Display*) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698