Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 380413002: Call DidStartNavigationToPendingEntry with correct argument. (Closed)

Created:
6 years, 5 months ago by dmazzoni
Modified:
6 years, 5 months ago
Reviewers:
ncarter (slow), nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Call DidStartNavigationToPendingEntry with correct argument. Calling it with render_frame_host is wrong because that object might have been deleted above. Only dest_render_frame_host is valid at this point. BUG=393032 TBR=nasko Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/frame_host/navigator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dmazzoni
6 years, 5 months ago (2014-07-10 23:08:39 UTC) #1
ncarter (slow)
lgtm
6 years, 5 months ago (2014-07-11 19:04:49 UTC) #2
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 5 months ago (2014-07-11 19:47:36 UTC) #3
dmazzoni
committing with TBR=nasko
6 years, 5 months ago (2014-07-11 19:47:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/380413002/1
6 years, 5 months ago (2014-07-11 19:48:00 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-12 01:09:16 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 04:48:29 UTC) #7
Message was sent while issue was closed.
Change committed as 282796

Powered by Google App Engine
This is Rietveld 408576698