Issue 380343002: aura: Make sure redirected events have the correct location.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 380343002: aura: Make sure redirected events have the correct location. (Closed)

Created:
6 years, 5 months ago by sadrul

Modified:
6 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, kalyank, ben+aura_chromium.org, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

aura: Make sure redirected events have the correct location. If an event is redirected to a different WindowTreeHost because the target window belongs to that, then make sure the event is in the WindowTreeHost's root-window's coordinate space. This is necessary to make sure that the target (and the pre/post-target handlers) see the event in the correct location. BUG=385770 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282794

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : fix-clang-build #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+199 lines, -9 lines)			Patch
M	ash/extended_desktop_unittest.cc	View		2 chunks	+132 lines, -0 lines	0 comments	Download
M	ui/aura/window_event_dispatcher_unittest.cc	View	1 2	2 chunks	+40 lines, -0 lines	0 comments	Download
M	ui/aura/window_targeter.cc	View		2 chunks	+27 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

6 years, 5 months ago (2014-07-12 04:46:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r282794 (presubmit successful).

Expand Messages | Collapse Messages