Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Unified Diff: Source/core/frame/LocalFrame.cpp

Issue 380303003: Enable resize and layout for frames with RemoteFrame ancestors (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: dcheng comments and rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/LocalFrame.cpp
diff --git a/Source/core/frame/LocalFrame.cpp b/Source/core/frame/LocalFrame.cpp
index 7d801447ee086cc95ec36cf16c02b687e1f3008b..6d88953244073fb50bab0076a1e986acd49aca14 100644
--- a/Source/core/frame/LocalFrame.cpp
+++ b/Source/core/frame/LocalFrame.cpp
@@ -343,15 +343,15 @@ void LocalFrame::createView(const IntSize& viewportSize, const Color& background
ASSERT(this);
ASSERT(page());
- bool isMainFrame = this->isMainFrame();
+ bool isLocalRoot = this->isLocalRoot();
- if (isMainFrame && view())
+ if (isLocalRoot && view())
view()->setParentVisible(false);
setView(nullptr);
RefPtr<FrameView> frameView;
- if (isMainFrame) {
+ if (isLocalRoot) {
frameView = FrameView::create(this, viewportSize);
// The layout size is set by WebViewImpl to support @viewport
@@ -365,7 +365,7 @@ void LocalFrame::createView(const IntSize& viewportSize, const Color& background
frameView->updateBackgroundRecursively(backgroundColor, transparent);
- if (isMainFrame)
+ if (isLocalRoot)
frameView->setParentVisible(true);
// FIXME: Not clear what the right thing for OOPI is here.

Powered by Google App Engine
This is Rietveld 408576698