Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: Source/web/WebPagePopupImpl.cpp

Issue 380303003: Enable resize and layout for frames with RemoteFrame ancestors (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: dcheng comments and rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 } 286 }
287 287
288 void WebPagePopupImpl::willCloseLayerTreeView() 288 void WebPagePopupImpl::willCloseLayerTreeView()
289 { 289 {
290 setIsAcceleratedCompositingActive(false); 290 setIsAcceleratedCompositingActive(false);
291 m_layerTreeView = 0; 291 m_layerTreeView = 0;
292 } 292 }
293 293
294 void WebPagePopupImpl::layout() 294 void WebPagePopupImpl::layout()
295 { 295 {
296 PageWidgetDelegate::layout(m_page.get()); 296 PageWidgetDelegate::layout(m_page.get(), 0);
eseidel 2014/07/11 16:33:03 Initially Confused by the 0. I now understand it,
kenrb 2014/07/11 20:03:33 I removed this change and made 0 the default argum
297 } 297 }
298 298
299 void WebPagePopupImpl::paint(WebCanvas* canvas, const WebRect& rect) 299 void WebPagePopupImpl::paint(WebCanvas* canvas, const WebRect& rect)
300 { 300 {
301 if (!m_closing) 301 if (!m_closing)
302 PageWidgetDelegate::paint(m_page.get(), 0, canvas, rect, PageWidgetDeleg ate::Opaque); 302 PageWidgetDelegate::paint(m_page.get(), 0, canvas, rect, PageWidgetDeleg ate::Opaque);
303 } 303 }
304 304
305 void WebPagePopupImpl::resize(const WebSize& newSize) 305 void WebPagePopupImpl::resize(const WebSize& newSize)
306 { 306 {
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 // A WebPagePopupImpl instance usually has two references. 394 // A WebPagePopupImpl instance usually has two references.
395 // - One owned by the instance itself. It represents the visible widget. 395 // - One owned by the instance itself. It represents the visible widget.
396 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the 396 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
397 // WebPagePopupImpl to close. 397 // WebPagePopupImpl to close.
398 // We need them because the closing operation is asynchronous and the widget 398 // We need them because the closing operation is asynchronous and the widget
399 // can be closed while the WebViewImpl is unaware of it. 399 // can be closed while the WebViewImpl is unaware of it.
400 return adoptRef(new WebPagePopupImpl(client)).leakRef(); 400 return adoptRef(new WebPagePopupImpl(client)).leakRef();
401 } 401 }
402 402
403 } // namespace blink 403 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698