Enable resize and layout for frames with RemoteFrame ancestors

Source/web/PageWidgetDelegate.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 51 matching lines @@
 
 void PageWidgetDelegate::animate(Page* page, double monotonicFrameBeginTime)
 {
     RefPtr<FrameView> view = mainFrameView(page);
     if (!view)
         return;
     page->autoscrollController().animate(monotonicFrameBeginTime);
     page->animator().serviceScriptedAnimations(monotonicFrameBeginTime);
 }
 
-void PageWidgetDelegate::layout(Page* page)
+void PageWidgetDelegate::layout(Page* page, LocalFrame* rootFrame)
 {
-    if (!page || !page->mainFrame())
+    if (!page)

[eseidel, 2014/07/11 16:33:03]

Why is it valid to call this method with a null page?

[kenrb, 2014/07/11 20:03:33]

It was added explicitly in r169672. I am not certain, but it looks like it is
needed for some unit tests.

[dcheng, 2014/07/11 21:22:52]

Do you mind filing a bug and assigning it to me? This is kind of bizarre;
ideally we should fix those tests rather than adding test-specific handling
here.

         return;
-    page->animator().updateLayoutAndStyleForPainting();
+
+    if (!rootFrame) {

[eseidel, 2014/07/11 16:33:03]

Why not make this a default =0 argument then?  Or is the goal that eventually
teh Page argument will be gone from this function and thus rootFrame makes sense
to be required?

[kenrb, 2014/07/11 20:03:33]

Done.

+        if (!page->mainFrame() || !page->mainFrame()->isLocalFrame())

[eseidel, 2014/07/11 16:33:03]

How can a page not have a mainFrame?  Or a page's mainFrame be remote?

[kenrb, 2014/07/11 20:03:33]

I don't know about a null mainFrame (see above revision number). However,
mainFrames can be remote when we are rendering an out-of-process iframe. The
entire frame tree has to be replicated, and all frames from the original process
(including the mainFrame) become remoteFrames in the child frame's process.

+            return;
+        rootFrame = toLocalFrame(page->mainFrame());
+    }
+
+    page->animator().updateLayoutAndStyleForPainting(rootFrame);
 }
 
 void PageWidgetDelegate::paint(Page* page, PageOverlayList* overlays, WebCanvas* canvas, const WebRect& rect, CanvasBackground background)
 {
     if (rect.isEmpty())
         return;
     GraphicsContext gc(canvas);
     gc.setCertainlyOpaque(background == Opaque);
     gc.applyDeviceScaleFactor(page->deviceScaleFactor());
     gc.setUseHighResMarkers(page->deviceScaleFactor() > 1.5f);
@@ skipping 118 matching lines @@
 {
     return mainFrame.eventHandler().handleWheelEvent(PlatformWheelEventBuilder(mainFrame.view(), event));
 }
 
 bool PageWidgetEventHandler::handleTouchEvent(LocalFrame& mainFrame, const WebTouchEvent& event)
 {
     return mainFrame.eventHandler().handleTouchEvent(PlatformTouchEventBuilder(mainFrame.view(), event));
 }
 
 }