Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 380263002: Fix windows compile, again. (Closed)

Created:
6 years, 5 months ago by Hannes Payer (out of office)
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M src/mark-compact.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mark-compact.cc View 1 1 chunk +5 lines, -5 lines 2 comments Download
M src/spaces.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Hannes Payer (out of office)
and another round...
6 years, 5 months ago (2014-07-10 16:15:47 UTC) #1
Dmitry Lomov (no reviews)
lgtm
6 years, 5 months ago (2014-07-10 16:20:24 UTC) #2
Dmitry Lomov (no reviews)
https://codereview.chromium.org/380263002/diff/40001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/380263002/diff/40001/src/mark-compact.cc#newcode4083 src/mark-compact.cc:4083: max_freed = static_cast<int>(SweepConservatively<SWEEP_IN_PARALLEL>( Please ASSERT no overflow
6 years, 5 months ago (2014-07-10 17:06:54 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/380263002/diff/40001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/380263002/diff/40001/src/mark-compact.cc#newcode4083 src/mark-compact.cc:4083: max_freed = static_cast<int>(SweepConservatively<SWEEP_IN_PARALLEL>( On 2014/07/10 17:06:54, Dmitry Lomov (chromium) ...
6 years, 5 months ago (2014-07-10 17:13:11 UTC) #4
Hannes Payer (out of office)
https://codereview.chromium.org/380263002/diff/40001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/380263002/diff/40001/src/mark-compact.cc#newcode4083 src/mark-compact.cc:4083: max_freed = static_cast<int>(SweepConservatively<SWEEP_IN_PARALLEL>( On 2014/07/10 17:06:54, Dmitry Lomov (chromium) ...
6 years, 5 months ago (2014-07-10 17:13:11 UTC) #5
Hannes Payer (out of office)
6 years, 5 months ago (2014-07-10 17:13:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r22331 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698