Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 380213002: An empty SVG path string is not in error (Closed)

Created:
6 years, 5 months ago by fs
Modified:
6 years, 5 months ago
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Project:
blink
Visibility:
Public.

Description

An empty SVG path string is not in error Adaption of Rob Buis' (<rwlbuis@webkit.org>; / <rob.buis@samsung.com>) WebKit patch. (http://trac.webkit.org/changeset/154896) BUG=264123 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177929

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : TestExpectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/platform/android/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/svg/custom/dynamic-empty-path-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/svg/dom/fuzz-path-parser.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/svg/dom/fuzz-path-parser-expected.txt View Binary file 0 comments Download
M LayoutTests/svg/dom/path-parser-expected.txt View 2 chunks +1 line, -1 line 0 comments Download
M LayoutTests/svg/dom/script-tests/path-parser.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGPathParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathUtilities.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rwlbuis
lgtm
6 years, 5 months ago (2014-07-10 12:59:08 UTC) #1
fs
6 years, 5 months ago (2014-07-10 13:16:57 UTC) #2
kouhei (in TOK)
lgtm
6 years, 5 months ago (2014-07-10 13:39:12 UTC) #3
fs
The CQ bit was checked by fs@opera.com
6 years, 5 months ago (2014-07-11 11:20:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/380213002/40001
6 years, 5 months ago (2014-07-11 11:21:07 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 11:24:44 UTC) #6
Message was sent while issue was closed.
Change committed as 177929

Powered by Google App Engine
This is Rietveld 408576698