Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 380153002: Revert "Support ES6 Map and Set in heap profiler" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-heap-profiler.cc
diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc
index 33528fbb03c29020309e294521829c30bb4312bc..db6b9da2a15aa1ea59a5342c1b8b83d619e6782e 100644
--- a/test/cctest/test-heap-profiler.cc
+++ b/test/cctest/test-heap-profiler.cc
@@ -502,10 +502,9 @@ TEST(HeapSnapshotWeakCollection) {
v8::HandleScope scope(env->GetIsolate());
v8::HeapProfiler* heap_profiler = env->GetIsolate()->GetHeapProfiler();
- CompileRun(
- "k = {}; v = {}; s = 'str';\n"
- "ws = new WeakSet(); ws.add(k); ws.add(v); ws[s] = s;\n"
- "wm = new WeakMap(); wm.set(k, v); wm[s] = s;\n");
+ CompileRun("k = {}; v = {};\n"
+ "ws = new WeakSet(); ws.add(k); ws.add(v);\n"
+ "wm = new WeakMap(); wm.set(k, v);\n");
const v8::HeapSnapshot* snapshot =
heap_profiler->TakeHeapSnapshot(v8_str("WeakCollections"));
CHECK(ValidateSnapshot(snapshot));
@@ -516,9 +515,6 @@ TEST(HeapSnapshotWeakCollection) {
const v8::HeapGraphNode* v =
GetProperty(global, v8::HeapGraphEdge::kProperty, "v");
CHECK_NE(NULL, v);
- const v8::HeapGraphNode* s =
- GetProperty(global, v8::HeapGraphEdge::kProperty, "s");
- CHECK_NE(NULL, s);
const v8::HeapGraphNode* ws =
GetProperty(global, v8::HeapGraphEdge::kProperty, "ws");
@@ -539,10 +535,6 @@ TEST(HeapSnapshotWeakCollection) {
}
}
CHECK_EQ(1, weak_entries);
- const v8::HeapGraphNode* ws_s =
- GetProperty(ws, v8::HeapGraphEdge::kProperty, "str");
- CHECK_NE(NULL, ws_s);
- CHECK_EQ(static_cast<int>(s->GetId()), static_cast<int>(ws_s->GetId()));
const v8::HeapGraphNode* wm =
GetProperty(global, v8::HeapGraphEdge::kProperty, "wm");
@@ -564,85 +556,6 @@ TEST(HeapSnapshotWeakCollection) {
}
}
CHECK_EQ(2, weak_entries);
- const v8::HeapGraphNode* wm_s =
- GetProperty(wm, v8::HeapGraphEdge::kProperty, "str");
- CHECK_NE(NULL, wm_s);
- CHECK_EQ(static_cast<int>(s->GetId()), static_cast<int>(wm_s->GetId()));
-}
-
-
-TEST(HeapSnapshotCollection) {
- i::FLAG_harmony_collections = true;
-
- LocalContext env;
- v8::HandleScope scope(env->GetIsolate());
- v8::HeapProfiler* heap_profiler = env->GetIsolate()->GetHeapProfiler();
-
- CompileRun(
- "k = {}; v = {}; s = 'str';\n"
- "set = new Set(); set.add(k); set.add(v); set[s] = s;\n"
- "map = new Map(); map.set(k, v); map[s] = s;\n");
- const v8::HeapSnapshot* snapshot =
- heap_profiler->TakeHeapSnapshot(v8_str("Collections"));
- CHECK(ValidateSnapshot(snapshot));
- const v8::HeapGraphNode* global = GetGlobalObject(snapshot);
- const v8::HeapGraphNode* k =
- GetProperty(global, v8::HeapGraphEdge::kProperty, "k");
- CHECK_NE(NULL, k);
- const v8::HeapGraphNode* v =
- GetProperty(global, v8::HeapGraphEdge::kProperty, "v");
- CHECK_NE(NULL, v);
- const v8::HeapGraphNode* s =
- GetProperty(global, v8::HeapGraphEdge::kProperty, "s");
- CHECK_NE(NULL, s);
-
- const v8::HeapGraphNode* set =
- GetProperty(global, v8::HeapGraphEdge::kProperty, "set");
- CHECK_NE(NULL, set);
- CHECK_EQ(v8::HeapGraphNode::kObject, set->GetType());
- CHECK_EQ(v8_str("Set"), set->GetName());
-
- const v8::HeapGraphNode* set_table =
- GetProperty(set, v8::HeapGraphEdge::kInternal, "table");
- CHECK_EQ(v8::HeapGraphNode::kArray, set_table->GetType());
- CHECK_GT(set_table->GetChildrenCount(), 0);
- int entries = 0;
- for (int i = 0, count = set_table->GetChildrenCount(); i < count; ++i) {
- const v8::HeapGraphEdge* prop = set_table->GetChild(i);
- const v8::SnapshotObjectId to_node_id = prop->GetToNode()->GetId();
- if (to_node_id == k->GetId() || to_node_id == v->GetId()) {
- ++entries;
- }
- }
- CHECK_EQ(2, entries);
- const v8::HeapGraphNode* set_s =
- GetProperty(set, v8::HeapGraphEdge::kProperty, "str");
- CHECK_NE(NULL, set_s);
- CHECK_EQ(static_cast<int>(s->GetId()), static_cast<int>(set_s->GetId()));
-
- const v8::HeapGraphNode* map =
- GetProperty(global, v8::HeapGraphEdge::kProperty, "map");
- CHECK_NE(NULL, map);
- CHECK_EQ(v8::HeapGraphNode::kObject, map->GetType());
- CHECK_EQ(v8_str("Map"), map->GetName());
-
- const v8::HeapGraphNode* map_table =
- GetProperty(map, v8::HeapGraphEdge::kInternal, "table");
- CHECK_EQ(v8::HeapGraphNode::kArray, map_table->GetType());
- CHECK_GT(map_table->GetChildrenCount(), 0);
- entries = 0;
- for (int i = 0, count = map_table->GetChildrenCount(); i < count; ++i) {
- const v8::HeapGraphEdge* prop = map_table->GetChild(i);
- const v8::SnapshotObjectId to_node_id = prop->GetToNode()->GetId();
- if (to_node_id == k->GetId() || to_node_id == v->GetId()) {
- ++entries;
- }
- }
- CHECK_EQ(2, entries);
- const v8::HeapGraphNode* map_s =
- GetProperty(map, v8::HeapGraphEdge::kProperty, "str");
- CHECK_NE(NULL, map_s);
- CHECK_EQ(static_cast<int>(s->GetId()), static_cast<int>(map_s->GetId()));
}
« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698