Issue 380123002: Mojo: Eliminate SyncDispatcher in favor of WaitForIncomingMethodCall

Issue 380123002: Mojo: Eliminate SyncDispatcher in favor of WaitForIncomingMethodCall (Closed)

Created:
6 years, 5 months ago by darin (slow to review)

Modified:
6 years, 5 months ago

Reviewers:
jamesr

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: Eliminate SyncDispatcher in favor of WaitForIncomingMethodCall Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282318

Patch Set 2 : remove old TODO comment #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -113 lines)			Patch
M	mojo/gles2/command_buffer_client_impl.h	View		5 chunks	+4 lines, -10 lines	0 comments	Download
M	mojo/gles2/command_buffer_client_impl.cc	View	1	7 chunks	+48 lines, -25 lines	0 comments	Download
M	mojo/mojo_public.gypi	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	mojo/public/cpp/bindings/BUILD.gn	View		2 chunks	+0 lines, -2 lines	0 comments	Download
D	mojo/public/cpp/bindings/lib/sync_dispatcher.cc	View		1 chunk	+0 lines, -27 lines	0 comments	Download
D	mojo/public/cpp/bindings/sync_dispatcher.h	View		1 chunk	+0 lines, -47 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://codereview.chromium.org/380123002/diff/1/mojo/gles2/command_buffer_client_impl.cc File mojo/gles2/command_buffer_client_impl.cc (right): https://codereview.chromium.org/380123002/diff/1/mojo/gles2/command_buffer_client_impl.cc#newcode108 mojo/gles2/command_buffer_client_impl.cc:108: // TODO(darin): We need better sugar for sync ...

6 years, 5 months ago (2014-07-10 05:50:38 UTC) #2

darin (slow to review)

https://codereview.chromium.org/380123002/diff/1/mojo/gles2/command_buffer_client_impl.cc File mojo/gles2/command_buffer_client_impl.cc (right): https://codereview.chromium.org/380123002/diff/1/mojo/gles2/command_buffer_client_impl.cc#newcode108 mojo/gles2/command_buffer_client_impl.cc:108: // TODO(darin): We need better sugar for sync calls. ...

6 years, 5 months ago (2014-07-10 06:02:08 UTC) #3

darin (slow to review)

The CQ bit was checked by darin@chromium.org

6 years, 5 months ago (2014-07-10 06:02:57 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/380123002/20001

6 years, 5 months ago (2014-07-10 06:03:52 UTC) #5

Message was sent while issue was closed.

Change committed as 282318

Expand Messages | Collapse Messages