content/browser/service_worker/service_worker_register_job_base.h - Issue 380093002: Update installed ServiceWorkers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job_base.h

Issue 380093002: Update installed ServiceWorkers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_register_job_base.h

diff --git a/content/browser/service_worker/service_worker_register_job_base.h b/content/browser/service_worker/service_worker_register_job_base.h

index 7995adda7c68294f9cf53bef9ed5b01264149831..55c4fbbcea67c12a1bf3045fd10ec1f83171386e 100644

--- a/content/browser/service_worker/service_worker_register_job_base.h

+++ b/content/browser/service_worker/service_worker_register_job_base.h

@@ -11,7 +11,7 @@ namespace content {

// job lives only for the lifetime of a single registration or unregistration.

class ServiceWorkerRegisterJobBase {

public:

- enum RegistrationJobType { REGISTRATION, UNREGISTRATION, };

+ enum RegistrationJobType { REGISTRATION, UNREGISTRATION, UPDATE_JOB };

falken 2014/07/10 03:45:32 bikeshed nit: "UPDATE" seems more consistent with

michaeln 2014/07/14 23:02:30 it does, but that collides with the Phase enum als

virtual ~ServiceWorkerRegisterJobBase() {}