Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1412)

Unified Diff: content/browser/service_worker/service_worker_register_job_base.h

Issue 380093002: Update installed ServiceWorkers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_register_job_base.h
diff --git a/content/browser/service_worker/service_worker_register_job_base.h b/content/browser/service_worker/service_worker_register_job_base.h
index 7995adda7c68294f9cf53bef9ed5b01264149831..9233e7c69af1a079053142c4d7f1f435b25f0533 100644
--- a/content/browser/service_worker/service_worker_register_job_base.h
+++ b/content/browser/service_worker/service_worker_register_job_base.h
@@ -7,11 +7,13 @@
namespace content {
falken 2014/07/17 06:33:41 I think some comment is still useful. "Base class
michaeln 2014/07/18 03:40:48 pet peevish, but i think we have too many comments
falken 2014/07/18 05:13:24 Yep I definitely agree about unneeded comments. I
-// A base class for ServiceWorkerRegisterJob and ServiceWorkerUnregisterJob. A
-// job lives only for the lifetime of a single registration or unregistration.
class ServiceWorkerRegisterJobBase {
public:
- enum RegistrationJobType { REGISTRATION, UNREGISTRATION, };
+ enum RegistrationJobType {
+ REGISTRATION_JOB,
+ UNREGISTRATION_JOB,
+ UPDATE_JOB
+ };
virtual ~ServiceWorkerRegisterJobBase() {}

Powered by Google App Engine
This is Rietveld 408576698