Issue 380073003: Fix provision_devices on the L-release preview.

Issue 380073003: Fix provision_devices on the L-release preview. (Closed)

Created:
6 years, 5 months ago by tonyg

Modified:
6 years, 5 months ago

Reviewers:
navabi1, jbudorick, Sami

CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix provision_devices on the L-release preview. Looks like we have to be a little more careful with the permissions now. Tested on LPV79. BUG=389362 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282373

Patch Set 1 #

Total comments: 1

Patch Set 2 : partial revert #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	build/android/provision_devices.py	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Sami

https://codereview.chromium.org/380073003/diff/1/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/380073003/diff/1/build/android/provision_devices.py#newcode130 build/android/provision_devices.py:130: device.RunShellCommand('echo %s > %s' % (adb_keys, constants.ADB_KEYS_FILE), Does this ...

6 years, 5 months ago (2014-07-10 11:26:38 UTC) #3

tonyg

OK, I've reverted those attempted changes and just left the necessary permission bits.

6 years, 5 months ago (2014-07-10 14:44:04 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/380073003/20001

6 years, 5 months ago (2014-07-10 15:36:08 UTC) #7

Message was sent while issue was closed.

Change committed as 282373

Expand Messages | Collapse Messages