Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: Source/core/dom/ContainerNode.h

Issue 380073002: Rename variables in ContainerNode::checkForSiblingStyleChanges() for clarity (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/ContainerNode.cpp » ('j') | Source/core/dom/ContainerNode.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011, 2013 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011, 2013 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 bool childrenAffectedByForwardPositionalRules() const { return hasRestyleFla g(ChildrenAffectedByForwardPositionalRules); } 144 bool childrenAffectedByForwardPositionalRules() const { return hasRestyleFla g(ChildrenAffectedByForwardPositionalRules); }
145 void setChildrenAffectedByForwardPositionalRules() { setRestyleFlag(Children AffectedByForwardPositionalRules); } 145 void setChildrenAffectedByForwardPositionalRules() { setRestyleFlag(Children AffectedByForwardPositionalRules); }
146 146
147 bool childrenAffectedByBackwardPositionalRules() const { return hasRestyleFl ag(ChildrenAffectedByBackwardPositionalRules); } 147 bool childrenAffectedByBackwardPositionalRules() const { return hasRestyleFl ag(ChildrenAffectedByBackwardPositionalRules); }
148 void setChildrenAffectedByBackwardPositionalRules() { setRestyleFlag(Childre nAffectedByBackwardPositionalRules); } 148 void setChildrenAffectedByBackwardPositionalRules() { setRestyleFlag(Childre nAffectedByBackwardPositionalRules); }
149 149
150 // FIXME: These methods should all be renamed to something better than "chec k", 150 // FIXME: These methods should all be renamed to something better than "chec k",
151 // since it's not clear that they alter the style bits of siblings and child ren. 151 // since it's not clear that they alter the style bits of siblings and child ren.
152 void checkForChildrenAdjacentRuleChanges(); 152 void checkForChildrenAdjacentRuleChanges();
153 enum SiblingCheckType { FinishedParsingChildren, SiblingRemoved, Other }; 153 enum SiblingCheckType { FinishedParsingChildren, SiblingRemoved, Other };
154 void checkForSiblingStyleChanges(SiblingCheckType, Node* beforeChange, Node* afterChange); 154 void checkForSiblingStyleChanges(SiblingCheckType, Node* nodeBeforeChange, N ode* nodeAfterChange);
155 155
156 bool childrenSupportStyleSharing() const { return !hasRestyleFlags(); } 156 bool childrenSupportStyleSharing() const { return !hasRestyleFlags(); }
157 157
158 // ------------------------------------------------------------------------- ---- 158 // ------------------------------------------------------------------------- ----
159 // Notification of document structure changes (see core/dom/Node.h for more notification methods) 159 // Notification of document structure changes (see core/dom/Node.h for more notification methods)
160 160
161 enum ChildrenChangeType { ChildInserted, ChildRemoved, AllChildrenRemoved, T extChanged }; 161 enum ChildrenChangeType { ChildInserted, ChildRemoved, AllChildrenRemoved, T extChanged };
162 enum ChildrenChangeSource { ChildrenChangeSourceAPI, ChildrenChangeSourcePar ser }; 162 enum ChildrenChangeSource { ChildrenChangeSourceAPI, ChildrenChangeSourcePar ser };
163 struct ChildrenChange { 163 struct ChildrenChange {
164 STACK_ALLOCATED(); 164 STACK_ALLOCATED();
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 inline void getChildNodes(Node& node, NodeVector& nodes) 325 inline void getChildNodes(Node& node, NodeVector& nodes)
326 { 326 {
327 ASSERT(!nodes.size()); 327 ASSERT(!nodes.size());
328 for (Node* child = node.firstChild(); child; child = child->nextSibling()) 328 for (Node* child = node.firstChild(); child; child = child->nextSibling())
329 nodes.append(child); 329 nodes.append(child);
330 } 330 }
331 331
332 } // namespace WebCore 332 } // namespace WebCore
333 333
334 #endif // ContainerNode_h 334 #endif // ContainerNode_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/ContainerNode.cpp » ('j') | Source/core/dom/ContainerNode.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698