Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 380053002: Fix remoting.Toolbar.setClientSession() to handle clientSession=null. (Closed)

Created:
6 years, 5 months ago by Sergey Ulanov
Modified:
6 years, 5 months ago
Reviewers:
Jamie, Wez, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix remoting.Toolbar.setClientSession() to handle clientSession=null. Previously setClientSession was trying to call clientSession when it's null. BUG=392345 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M remoting/webapp/toolbar.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Sergey Ulanov
6 years, 5 months ago (2014-07-09 23:13:15 UTC) #1
kelvinp
lgtm
6 years, 5 months ago (2014-07-10 01:09:13 UTC) #2
kelvinp
You will need another LGTM from a committer in order to check this in though.
6 years, 5 months ago (2014-07-10 01:09:36 UTC) #3
Wez
lgtm
6 years, 5 months ago (2014-07-10 01:16:36 UTC) #4
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-10 01:23:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/380053002/1
6 years, 5 months ago (2014-07-10 01:24:54 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 08:13:50 UTC) #7
Message was sent while issue was closed.
Change committed as 282284

Powered by Google App Engine
This is Rietveld 408576698