Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 380023005: Mojo: Mojom: Add Import, ImportList, and Mojom AST types. (Closed)

Created:
6 years, 5 months ago by viettrungluu
Modified:
6 years, 5 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Mojom: Add Import, ImportList, and Mojom AST types. R=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -236 lines) Patch
M mojo/public/tools/bindings/pylib/mojom/parse/ast.py View 5 chunks +33 lines, -5 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 2 chunks +13 lines, -14 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/translate.py View 1 chunk +13 lines, -22 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/parser_unittest.py View 15 chunks +241 lines, -195 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 5 months ago (2014-07-10 00:11:17 UTC) #1
DaveMoore
lgtm
6 years, 5 months ago (2014-07-10 19:42:09 UTC) #2
viettrungluu
6 years, 5 months ago (2014-07-10 20:31:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r282418 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698