Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 380023002: Move Password specific webdata logic into passwords component. (Closed)

Created:
6 years, 5 months ago by Cait (Slow)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, tim+watch_chromium.org, browser-components-watch_chromium.org, zea+watch_chromium.org, benquan, tfarina, haitaol+watch_chromium.org, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move Password specific webdata logic into passwords component. BUG=181277 TEST=Everything still works TBR=shess@chromium.org, gab@chromium.org (shess@ for logins_table, gab@ for profile_writer both file-moves) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283658

Patch Set 1 #

Patch Set 2 : Fix upstream #

Patch Set 3 : Rebase #

Patch Set 4 : remove old files #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -362 lines) Patch
M chrome/browser/importer/profile_writer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_win_unittest.cc View 1 2 3 4 2 chunks +5 lines, -3 lines 0 comments Download
D chrome/browser/webdata/logins_table.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/webdata/logins_table.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/webdata/logins_table_win.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/webdata/password_web_data_service_win.h View 1 2 3 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/webdata/password_web_data_service_win.cc View 1 2 3 1 chunk +0 lines, -78 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 1 2 4 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M components/password_manager.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/DEPS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A + components/password_manager/core/browser/webdata/logins_table.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/password_manager/core/browser/webdata/logins_table.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/password_manager/core/browser/webdata/logins_table_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/password_manager/core/browser/webdata/password_web_data_service_win.h View 1 2 3 5 chunks +7 lines, -5 lines 0 comments Download
A + components/password_manager/core/browser/webdata/password_web_data_service_win.cc View 1 2 3 2 chunks +9 lines, -15 lines 0 comments Download
M components/webdata/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/webdata/common/web_database_migration_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Cait (Slow)
pkasting: PTAL at c/b/webdata and components/webdata gastro: PTAL at c/b/password_manager and components/password_manager This is mostly ...
6 years, 5 months ago (2014-07-14 23:17:17 UTC) #1
Peter Kasting
LGTM
6 years, 5 months ago (2014-07-14 23:18:38 UTC) #2
Garrett Casto
lgtm
6 years, 5 months ago (2014-07-15 21:42:37 UTC) #3
Cait (Slow)
The CQ bit was checked by caitkp@chromium.org
6 years, 5 months ago (2014-07-16 22:06:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/380023002/80001
6 years, 5 months ago (2014-07-16 22:09:16 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 06:19:51 UTC) #6
Message was sent while issue was closed.
Change committed as 283658

Powered by Google App Engine
This is Rietveld 408576698