Issue 380010: [Mac] Fix a leak in HyperlinkButtonCell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 380010: [Mac] Fix a leak in HyperlinkButtonCell (Closed)

Created:
11 years, 1 month ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs), Nico

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

[Mac] Fix a leak in HyperlinkButtonCell BUG=27149 TEST=Valgrind Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31558

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -27 lines)			Patch
	M	chrome/browser/cocoa/hyperlink_button_cell.mm	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	tools/valgrind/memcheck/suppressions_mac.txt	View		1 chunk	+0 lines, -26 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

drive-by http://codereview.chromium.org/380010/diff/1/2 File chrome/browser/cocoa/hyperlink_button_cell.mm (right): http://codereview.chromium.org/380010/diff/1/2#newcode65 Line 65: NSMutableParagraphStyle* paragraphStyle = the best (and more ...

11 years, 1 month ago (2009-11-11 17:00:33 UTC) #3

pink (ping after 24hrs)

11 years, 1 month ago (2009-11-11 17:01:19 UTC) #4

drive-by


http://codereview.chromium.org/380010/diff/1/2
File chrome/browser/cocoa/hyperlink_button_cell.mm (right):

http://codereview.chromium.org/380010/diff/1/2#newcode65
Line 65: NSMutableParagraphStyle* paragraphStyle =
the best (and more consistent) fix here would be to use a
scoped_nsobject, but good catch.

http://codereview.chromium.org/380010

Expand Messages | Collapse Messages