Implement the PAC js-binding for "myIpAddress()".

Implement the PAC js-binding for "myIpAddress()".

BUG=2764
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10824

[darin (slow to review), 2009-03-03 17:30:48]

Looks good... just a couple suggestions:

http://codereview.chromium.org/38001/diff/2001/3004
File net/base/net_util.cc (right):

http://codereview.chromium.org/38001/diff/2001/3004#newcode1051
Line 1051: return std::string();
nit: could also write:  buffer[0] = '\0';

that might result in a tad less code

http://codereview.chromium.org/38001/diff/2001/3002
File net/proxy/proxy_resolver_v8.cc (right):

http://codereview.chromium.org/38001/diff/2001/3002#newcode66
Line 66: return DnsResolve(my_hostname);
maybe DnsResolve should just return std::string whenever the input is an empty
string.  then this code could just be:

return DnsResolve(GetMyHostName());

[darin (slow to review), 2009-03-03 17:37:25]

Looks good... just a couple suggestions:

[eroman, 2009-03-03 19:37:45]

thanks for review.

http://codereview.chromium.org/38001/diff/2001/3004
File net/base/net_util.cc (right):

http://codereview.chromium.org/38001/diff/2001/3004#newcode1051
Line 1051: return std::string();
I am not sure if I am understanding the suggestion properly. Is it to do:

if (fail) {
  LOG
  buffer[0] = '\0';
}

return buffer;

or to do:

char buffer[XXX];
buffer[0] = '\0';

result = XXX(buffer);
if (!result)
  LOG

return buffer;  // assume it is still '\0'


I think I prefer return std::string(), but I can change.
Will save this as a follow up, making sure to do the same  thing in
NetAddressToString() for consistency.

http://codereview.chromium.org/38001/diff/2001/3002
File net/proxy/proxy_resolver_v8.cc (right):

http://codereview.chromium.org/38001/diff/2001/3002#newcode66
Line 66: return DnsResolve(my_hostname);
On 2009/03/03 17:30:48, darin wrote:
> maybe DnsResolve should just return std::string whenever the input is an empty
> string.  then this code could just be:
> 
> return DnsResolve(GetMyHostName());
j

http://codereview.chromium.org/38001/diff/2001/3002#newcode66
Line 66: return DnsResolve(my_hostname);
On 2009/03/03 17:30:48, darin wrote:
> maybe DnsResolve should just return std::string whenever the input is an empty
> string.  then this code could just be:
> 
> return DnsResolve(GetMyHostName());

Done.

I generated a TODO, as I am not quite sure what dnsResolve("") needs to return
from a compatibility standpoint.

Experimentally on windows, the first address in the resolved list for "" was my
own IP addresss.
However on Mac OS X it came out as "::1".

I will test to see what Firefox/IE do...

[darin (slow to review), 2009-03-03 19:43:54]

LGTM

http://codereview.chromium.org/38001/diff/2001/3004
File net/base/net_util.cc (right):

http://codereview.chromium.org/38001/diff/2001/3004#newcode1051
Line 1051: return std::string();
i meant the former.  in the error case, stamp a null byte so you can just resume
on the "success" path.

anyways, just a suggestion...